i3status-rust: use mkTarget

[awwpotato]

Submission Checklist

• I certify that I have the right to submit this contribution under the MIT license
• Commit messages adhere to Stylix commit conventions
• Theming changes adhere to the Stylix style guide
• Changes have been tested locally
• Changes have been tested in testbeds
• Each commit in this PR is suitable for backport to the current stable branch

Notify Maintainers

@mightyiam

[trueNAHO]

LGTM.

[awwpotato]

made the color part work when opacity is null

[trueNAHO]

LGTM, but hard to say whether this truly works without any testing.

[mightyiam]

Sorry. It's on my list.

[mightyiam]

I took a moment to try and got this:

error: The option `home-manager.users.mightyiam.programs.i3status-rust.bars.bottom.critical_bg' does not exist. Definition values:
       - In `/nix/store/rdck24kjc8l8p6c2gvmg1kkvcfh1akpk-source/inputs/stylix/modules/i3status-rust/hm.nix': "#fb4934D9"

Perhaps the way in which I am currently applying the provided style would help:
https://github.com/mightyiam/infra/blob/e5a843d957ffea7f1691733a8b1780fd15bb7cca/modules/window-manager/bars.nix#L14

[mightyiam]

I think it should be like this. I'm going to paste the entire file here.:

{ mkTarget, lib, ... }:
let
  themeOverrides =
    { cfg, colors }:
    lib.mapAttrs (n: v: if lib.hasSuffix "_bg" n then v + cfg.bgOpacity else v) (
      with colors.withHashtag;
      {
        idle_bg = base00;
        idle_fg = base05;
        info_bg = base09;
        info_fg = base00;
        good_bg = base01;
        good_fg = base05;
        warning_bg = base0A;
        warning_fg = base00;
        critical_bg = base08;
        critical_fg = base00;
        separator_bg = base00;
        separator_fg = base05;
      }
    );
in
mkTarget {
  name = "i3status-rust";
  humanName = "i3status-rust";

  extraOptions = {
    barNames = lib.mkOption {
      type = with lib.types; listOf str;
      default = [ ];
      description = "i3status-rust bars to apply theming to.";
      example = [ "default" ];
    };
    bgOpacity = lib.mkOption {
      type = lib.types.float;
      default = 1.0;
      internal = true;
      apply = v: lib.toHexString (builtins.ceil (v * 255));
    };
  };

  imports = lib.singleton (
    { config, ... }:
    {
      lib.stylix.i3status-rust.bar =
        lib.warn
          "stylix: `config.lib.stylix.i3status-rust.bar` has been replace with `config.stylix.targets.i3status-rust.barNames` and will be removed after 26.11."
          (themeOverrides {
            cfg = config.stylix.targets.i3status-rust;
            inherit (config.lib.stylix) colors;
          });
    }
  );

  configElements = [
    (
      { opacity }:
      {
        stylix.targets.i3status-rust.bgOpacity = opacity.desktop;
      }
    )
    (
      { cfg, colors }:
      {
        programs.i3status-rust.bars = lib.genAttrs cfg.barNames (_: {
          settings.theme.overrides = themeOverrides { inherit cfg colors; };
        });
      }
    )
  ];
}

[mightyiam]

With the contents of the file I pasted above, I have tested both the lib usage that comes with a warning and the new barNames option. In both cases there were no changes to my home derivation. Oh, and for reference:
https://github.com/greshake/i3status-rust/blob/db4db28eda9bbf8b7fc61ddad65a00207be9368b/examples/config.toml

[Flameopathic]

@awwpotato what is the status of this PR?