Skip to content

Conversation

theanarkh
Copy link
Contributor

const vm = require('vm');
const trace_events = require('trace_events');

trace_events.createTracing({ categories: ['node.perf'] }).enable();

new vm.Script('while(1) {}').runInThisContext({breakOnSigint: true, timeout: 100000});
5dff6e25-5eda-4c2f-8266-e9e01a97e642
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 23, 2025
@theanarkh theanarkh force-pushed the set_name_for_more_thread branch from 539ecc5 to effdace Compare August 23, 2025 19:04
Copy link

codecov bot commented Aug 23, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.85%. Comparing base (bdcab71) to head (329cbae).
⚠️ Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
src/tracing/agent.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59601      +/-   ##
==========================================
- Coverage   89.86%   89.85%   -0.02%     
==========================================
  Files         664      667       +3     
  Lines      194944   196263    +1319     
  Branches    38285    38561     +276     
==========================================
+ Hits       175180   176345    +1165     
- Misses      12229    12371     +142     
- Partials     7535     7547      +12     
Files with missing lines Coverage Δ
src/node_platform.cc 76.24% <100.00%> (+0.04%) ⬆️
src/node_watchdog.cc 72.19% <100.00%> (+0.25%) ⬆️
src/tracing/agent.cc 90.06% <0.00%> (ø)

... and 70 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 24, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 25, 2025
@theanarkh theanarkh force-pushed the set_name_for_more_thread branch from effdace to 329cbae Compare August 26, 2025 13:43
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 27, 2025
@nodejs-github-bot nodejs-github-bot merged commit 83c955d into nodejs:main Aug 27, 2025
60 of 61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 83c955d

targos pushed a commit that referenced this pull request Aug 28, 2025
PR-URL: #59601
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants