-
Notifications
You must be signed in to change notification settings - Fork 601
feat(deps): update deps matching '@opentelemetry/*' #3013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): update deps matching '@opentelemetry/*' #3013
Conversation
Hmm, looks like some tooling error. |
I'm looking at the issue. |
Updated the branch to get the #3017 fix. |
Presumably this got a bit further. The |
All the other unit-test versions failed in test-all-versions of instr-redis (in the v2-v3 tests):
As well the
|
I cannot repro the instr-redis test-all-versions test failures locally. npm run test-all-versions:with-services-env -w @opentelemetry/instrumentation-redis
# OR
cd packages/instrumentation-redis
npm run test-all-versions:with-services-env I've created #3019 to try to play with this in CI independent of this PR. |
Oh, I can reproduce the instr-redis TAV failures with the deps changes in this PR. My "could not repro" above was just trying on "main" -- falsely assuming David's recent test workflow changes were at fault. Duh. So the current failures are legitimate test failures for the changes in this PR. |
I personally am super-excited to dig into why recent core-repo otel package changes are breaking instr-redis test for this redis release from 2021 and earlier versions.
|
Well, I feel like this is unhelpful of npm:
... and unsurprisingly the redis test for v2-v3 fail when using redis v5. |
^^^ That was with these node/npm versions:
Same thing with node v22.17.1 (npm v10.9.2). With node v24.6.0 (npm v11.5.1) it works:
and that'll likely be why Yuck. We can force install the latest npm in CI... but shouldn't have to live with the situation where running TAV locally is basically useless because you don't know if it's able to install the versions of deps it asks for. Makes one want to burn npm to the ground. Perhaps looking at pnpm or yarn, though that is a big step... and would, for example, require updating TAV to support using one of those package managers. |
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
This run in a different PR succeeded to run test-all-versions with in redis package https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/17476483680/job/49637949647?pr=2975 which makes this issue even more strange. |
With the patched tav, the only test failures I've seen so far were due to the flaky tests (some connections timing out, etc). None were caused by installation issues yet (well, apart from a new version of @aws-sdk/client-bedrock-runtime getting released yesterday at the same time as the tests were running and then disappearing for a bit and reappearing again). |
I think the "npm install doesn't install the thing" depends on the state of the package-lock file (or the existing node_modules/... tree). The package-lock.json changes in this PR are sufficient to tickle this |
I guess this one superseded by #3027 right @pichlermarc ? |
Updates all
@opentelemetry/*
dependencies to latest