-
Notifications
You must be signed in to change notification settings - Fork 603
fix: fix test-all-versions script #3017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3017 +/- ##
==========================================
+ Coverage 90.54% 91.44% +0.89%
==========================================
Files 112 146 +34
Lines 6083 8192 +2109
Branches 1349 1846 +497
==========================================
+ Hits 5508 7491 +1983
- Misses 575 701 +126
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
"test": "nx run-many -t test", | ||
"test:ci:affected": "nx affected -t test", | ||
"test:browser": "nx run-many -t test:browser", | ||
"test:browser:ci:affected": "nx affected -t test:browser", | ||
"test-all-versions": "nx run-many --parallel=false -t test-all-versions", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nx sets process.env.npm_config_legacy_peer_deps = true
, which messes with installation in tav. I had to unset it in the tav patch to make everything work. Could also affect regular tav installs.
@@ -22,8 +22,9 @@ | |||
"test-v5-v6": "nyc mocha --require '@opentelemetry/contrib-test-utils' 'test/mongoose-common.test.ts' 'test/**/mongoose-v5-v6.test.ts'", | |||
"test-v7-v8": "nyc mocha --require '@opentelemetry/contrib-test-utils' 'test/mongoose-common.test.ts' 'test/**/mongoose-v7-v8.test.ts'", | |||
"test:with-services-env": "cross-env NODE_OPTIONS='-r dotenv/config' DOTENV_CONFIG_PATH=../../test/test-services.env npm test", | |||
"test-all-versions": "tav", | |||
"test-all-versions": "tav", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
"test-all-versions": "tav", | |
"test-all-versions": "tav", |
Which problem is this PR solving?
The PR adding the new test workflow passed but had some issues:
pg
Now we are having TAV failures in PRs like #3013. Is not for the missing script but it seems
nx
is providing a different context thannpm run --workspaces
The following command
fails giving different messages, the most common is
But the following command succeds
Is just a guess but maybe
nx
is also modifying the node_modules tree and affecting installations of the packages fromtest-all-versions
.Short description of the changes