Skip to content

Conversation

mmanciop
Copy link

This PR renames peer.service to peer.service.name and introduces peer.service.namespace with the intention of supporting match the usage of service.namespace + service.name as identity for services.

This PR partly fulfils #2338

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

This PR renames peer.service to peer.service.name and introduces peer.service.namespace with the intention of supporting match the usage of service.namespace + service.name as identity for services.

This PR partly fulfils open-telemetry#2338
@mmanciop mmanciop changed the title Peer update Update peer.* namespace to account for service.namespace Sep 25, 2025
@github-actions github-actions bot added enhancement New feature or request area:peer labels Sep 25, 2025
@mmanciop
Copy link
Author

Mmm on second thought, I am starting to see too many dependencies to peer.service in various implementations:

Maybe a better option would be to add a peer.service_namespace attribute instead, and forsake symmetry with the service namespace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:peer enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant