Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .chloggen/2807-update-peer-namespace.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement
component: peer
note: Update peer.* namespace to mirror service.*.
issues: [2807]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: |
Rename peer.service to peer.service.name and introduces peer.service.namespace
to support matching the usage of service.namespace + service.name as identity
for services.
3 changes: 2 additions & 1 deletion docs/general/attributes.md
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,8 @@ Instrumentations SHOULD provide a way for users to configure this name.

| Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability |
|---|---|---|---|---|---|
| [`peer.service`](/docs/registry/attributes/peer.md) | string | The [`service.name`](/docs/resource/README.md#service) of the remote service. SHOULD be equal to the actual `service.name` resource attribute of the remote service if any. | `AuthTokenCache` | `Recommended` | ![Development](https://img.shields.io/badge/-development-blue) |
| [`peer.service.name`](/docs/registry/attributes/peer.md) | string | The [`service.name`](/docs/resource/README.md#service) of the remote service. SHOULD be equal to the actual `service.name` resource attribute of the remote service if any. | `shoppingcart` | `Recommended` | ![Development](https://img.shields.io/badge/-development-blue) |
| [`peer.service.namespace`](/docs/registry/attributes/peer.md) | string | The [`service.namespace`](/docs/resource/README.md#service) of the remote service. SHOULD be equal to the actual `service.namespace` resource attribute of the remote service if any. | `Shop` | `Recommended` | ![Development](https://img.shields.io/badge/-development-blue) |

<!-- markdownlint-restore -->
<!-- prettier-ignore-end -->
Expand Down
4 changes: 3 additions & 1 deletion docs/registry/attributes/peer.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ Operations that access some remote service.

| Attribute | Type | Description | Examples | Stability |
|---|---|---|---|---|
| <a id="peer-service" href="#peer-service">`peer.service`</a> | string | The [`service.name`](/docs/resource/README.md#service) of the remote service. SHOULD be equal to the actual `service.name` resource attribute of the remote service if any. | `AuthTokenCache` | ![Development](https://img.shields.io/badge/-development-blue) |
| <a id="peer-service" href="#peer-service">`peer.service`</a> | string | The [`service.name`](/docs/resource/README.md#service) of the remote service. SHOULD be equal to the actual `service.name` resource attribute of the remote service if any. | `AuthTokenCache` | ![Deprecated](https://img.shields.io/badge/-deprecated-red)<br>Replaced by `peer.service.name`. |
| <a id="peer-service-name" href="#peer-service-name">`peer.service.name`</a> | string | The [`service.name`](/docs/resource/README.md#service) of the remote service. SHOULD be equal to the actual `service.name` resource attribute of the remote service if any. | `shoppingcart` | ![Development](https://img.shields.io/badge/-development-blue) |
| <a id="peer-service-namespace" href="#peer-service-namespace">`peer.service.namespace`</a> | string | The [`service.namespace`](/docs/resource/README.md#service) of the remote service. SHOULD be equal to the actual `service.namespace` resource attribute of the remote service if any. | `Shop` | ![Development](https://img.shields.io/badge/-development-blue) |
4 changes: 3 additions & 1 deletion model/peer/common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@ groups:
type: attribute_group
brief: "Operations that access some remote service."
attributes:
- ref: peer.service
- ref: peer.service.name
requirement_level: recommended
- ref: peer.service.namespace
requirement_level: recommended
19 changes: 19 additions & 0 deletions model/peer/registry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,22 @@ groups:
of the remote service. SHOULD be equal to the actual `service.name`
resource attribute of the remote service if any.
examples: "AuthTokenCache"
deprecated:
reason: renamed
renamed_to: peer.service.name
- id: peer.service.name
type: string
stability: development
brief: >
The [`service.name`](/docs/resource/README.md#service)
of the remote service. SHOULD be equal to the actual `service.name`
resource attribute of the remote service if any.
examples: "shoppingcart"
- id: peer.service.namespace
type: string
stability: development
brief: >
The [`service.namespace`](/docs/resource/README.md#service)
of the remote service. SHOULD be equal to the actual `service.namespace`
resource attribute of the remote service if any.
examples: "Shop"
Loading