Fix metric.v8js.memory.heap.space.physical_size and metric.v8js.memory.heap.space.available_size metric names
#2856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopgrassi
reviewed
Oct 2, 2025
|
cc @open-telemetry/javascript-approvers |
trentm
changed the title
metric.v8js.memory.heap.space.physical_size and metric.v8js.memory.heap.space.available_size metric names
trentm
approved these changes
Oct 2, 2025
trentm
added a commit
to trentm/opentelemetry-js-contrib
that referenced
this pull request
Oct 2, 2025
joaopgrassi
approved these changes
Oct 6, 2025
Merged
via the queue into
open-telemetry:main
with commit Oct 6, 2025
f1b1d72
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Aligning the name of metrics related to memory heap. Currently some of them don't have the
memoryin its name. We did the implementation for it in the JS SDK, using all the metric names withmemory. It was a mistake on the semantic convention, and it should also have thememoryon the name here.This PR marks the previous name as deprecated (there is no implementation using those names anyway), and update the names.
Reference: open-telemetry/opentelemetry-js-contrib#3130 (comment)
Merge requirement checklist
[chore]