-
Notifications
You must be signed in to change notification settings - Fork 103
Update supported library versions #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
] | ||
} | ||
] | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnestoro can we add the missing end of line here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I usually do that. Will do it later.
"13.1.1.jre11-preview", | ||
"13.1.1.jre8-preview", | ||
"13.2.0.jre11", | ||
"13.2.0.jre8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnestoro are all of these libraries tested when we run our gates or only the latest one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we run this periodic job for scanning, we test all new versions that you marked in the comment. Once merged, we only test "original" version (the version that metadata was originally provided for). Since tests and metadata already work for all versions in the list, we can pick any of them, but the existing infrastructure (before we introduced this task) used original version and I kept that.
c0d26a8
to
e12afbb
Compare
This pull request updates supported versions of the existing libraries in the repo