Update supported library versions #670
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,7 +44,8 @@ | |
| "1.50.0", | ||
| "1.51.0", | ||
| "1.52.0", | ||
| "1.53.0", | ||
| "1.54.0" | ||
| ] | ||
| } | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,24 @@ | ||
| [ | ||
| { | ||
| "latest" : false, | ||
| "override" : true, | ||
| "module" : "io.opentelemetry:opentelemetry-sdk-metrics", | ||
| "metadata-version" : "1.19.0", | ||
| "tested-versions" : [ | ||
| "1.19.0", | ||
| "1.20.0", | ||
| "1.20.1", | ||
| "1.21.0", | ||
| "1.22.0", | ||
| "1.23.0", | ||
| "1.23.1", | ||
| "1.24.0", | ||
| "1.25.0", | ||
| "1.26.0", | ||
| "1.27.0", | ||
| "1.28.0", | ||
| "1.29.0", | ||
| "1.30.0" | ||
| ] | ||
| } | ||
| ] | ||
|
There was a problem hiding this comment. @dnestoro can we add the missing end of line here? There was a problem hiding this comment. Yes, I usually do that. Will do it later. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,7 +19,8 @@ | |
| "9.0.0.Beta3", | ||
| "9.0.0.CR1", | ||
| "9.0.0.Final", | ||
| "9.0.1.Final", | ||
| "9.1.0.Alpha1" | ||
| ] | ||
| } | ||
| ] | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnestoro are all of these libraries tested when we run our gates or only the latest one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we run this periodic job for scanning, we test all new versions that you marked in the comment. Once merged, we only test "original" version (the version that metadata was originally provided for). Since tests and metadata already work for all versions in the list, we can pick any of them, but the existing infrastructure (before we introduced this task) used original version and I kept that.