fix: Resolve AttributeError when generating log filename #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix AttributeError: module 'datetime' has no attribute 'now'
tavallaie
reviewed
Oct 11, 2025
|
|
||
| if self.verbose: | ||
| log_filename = self.log_filename or datetime.now().strftime( | ||
| log_filename = self.log_filename or datetime.datetime.now().strftime( |
There was a problem hiding this comment.
Thanks for noticing the problem.
I would like make it add:
from datetime import datetime
at the top of the file instead of datetime.datetime.now()
what do you think about the change?
|
Also maybe it in not a bad idea to separate logger logic from the rest of the modules. |
ChuckHend
approved these changes
Oct 11, 2025
I think that makes sense. It would be great if logging became overall easier to configure too. But that should be done in another PR. I think this one is good to go. |
|
So for now, I also approved it. I will make another PR for logging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug that caused an AttributeError: module 'datetime' has no attribute 'now' when initializing logging in verbose mode.
The error occurred because the code was incorrectly calling datetime.now() instead of the correct datetime.datetime.now().
This change updates the method call to correctly reference the datetime class within the datetime module, ensuring that the timestamp for the log filename is generated without errors.