Skip to content

fix: Resolve AttributeError when generating log filename #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2025
Merged

fix: Resolve AttributeError when generating log filename #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a93a9
Fix AttributeError: module 'datetime' has no attribute 'now'
Malayke Oct 4, 2025
a217a3e
Merge pull request #1 from Malayke/fix-datetime-attribute-error
Malayke Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pgmq/queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def _initialize_logging(self) -> None:
self.logger = logging.getLogger(__name__)

if self.verbose:
log_filename = self.log_filename or datetime.now().strftime(
log_filename = self.log_filename or datetime.datetime.now().strftime(
Copy link
Collaborator

@tavallaie tavallaie Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing the problem.
I would like make it add:
from datetime import datetime
at the top of the file instead of datetime.datetime.now()
what do you think about the change?

"pgmq_debug_%Y%m%d_%H%M%S.log"
)
file_handler = logging.FileHandler(
Expand Down