Fix issue #18598: Duplicating a class fails to log methods in Epicea

[carolahp]

As @akgrant43 pointed out in Issue #18598, Epicea was not logging method creation entries when duplicating classes, because the announcer was silenced in Behavior>>#recompile:from:.

My solution preserves the silence for method recompilations, but ensures that method compilations always announce their code changes.
As a result, Behavior>>compileAllFrom: now announces its changes. This is correct, since it is only used when copying methods from an existing class into a new one—the exact scenario that was failing in the original issue.

I also added a test to verify that Epicea entries are correctly created when copying methods from an existing class.

[jecisc]

About announcements do not hesitate to add a test in MethodAnnouncementsTest or other subclasses of AbstractClassDescriptionAnnouncementTest :)

I fixed multiple bugs in the announcements and I try to keep those classes to ensure there is no regression

[carolahp]

Thanks @jecisc ,
one of the exrea test (MethodAnnouncementsTest>>#testCompileMethodByDuplicatingAClassAnnounceAddition) made me realize that duplicated methods were still in UnpackagedPackage at the momment their creation is announced.

I modified the builder to set the package before the method added announcement :)

[jecisc]

Thank you!
I'm glad this helped you to fix another bug :)

[tesonep]

Hi @carolahp, this PR once integrated will be nice to port to P13 and P14.

[carolahp]

Hi @carolahp, this PR once integrated will be nice to port to P13 and P14.

Hi @tesonep , sure!

[jecisc]

Lot of tests are breaking

[Ducasse]

Strange the build did not finish. I will relaunch it.

[Ducasse]

@demarey I could not restart the build because I lost my ci credential. could you restart it?

[carolahp]

@Ducasse @demarey I have access... I just restarted it

[jecisc]

We had to restart Jenkins because it was not responding. It probably stopped the build. Sorry for the inconvenience

[Ducasse]

Trying to kick the build again. I updated the branch to see.
I'm not sure that it was a good idea. @tesonep I will probably need your help. May I fucked up something.

[carolahp]

I decided to close this PR and split it in 2:

• PR#18706 solves the original issue with Epicea
• PR#18707 solves the bugs I found later, but it needs more work!

@Ducasse I will close this PR