Fix issue #18598: Duplicating a class fails to log methods in Epicea (clean) #18706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolahp
changed the title
Contributor
Author
|
Failing tests are unrelated to this PR |
Ducasse
reviewed
Oct 17, 2025
Member
|
hi @carolahp check my comments :) |
Contributor
Author
akgrant43
added a commit
to feenkcom/gt4pharo
that referenced
this pull request
Nov 3, 2025
Pharo have implemented a different fix for this in Pharo 14, so this should be reviewed as part of the upgrade to Pharo 14. See pharo-project/pharo#18706
syrel
pushed a commit
to feenkcom/gtoolkit
that referenced
this pull request
Nov 4, 2025
Metacello new
baseline: 'GToolkitForPharo9';
repository: 'github://feenkcom/gtoolkit:v1.0.2284/src';
load
All commits (including upstream repositories) since last build:
feenkcom/gtoolkit-vm-bindings@11213f by Aliaksei Syrel
add a source view to the tonel method definition
feenkcom/gtoolkit-vm-bindings@6f2bfc by Aliaksei Syrel
do not pre-process bare ffi call arguments
feenkcom/gtoolkit-vm-bindings@9a16f8 by Aliaksei Syrel
Declare Character as unsigned char in bare ffi
feenkcom/gtoolkit-boxer@403735 by Aliaksei Syrel
[#4826] #release should not remove the ephemeron
feenkcom/gtoolkit-boxer@139ad7 by Aliaksei Syrel
added ArrayU8/U16 and String ffi traits that use bare ffi
feenkcom/sparta@e15e9d by Aliaksei Syrel
in skia, move arrayU8 and arrayU16 api to bare ffi
feenkcom/Bloc@4f23da by Aliaksei Syrel
add a quick return to BlElement>>#opacity: when a new value is the same
feenkcom/Brick@1f1e7d by Andrei Chi�
Merge c5104026be8f4f9ea2638a75734f475525053dc9
feenkcom/Brick@5516bf by Andrei Chi�
Disable blinking for now
feenkcom/Brick@c51040 by Oscar Nierstrasz
Added a UI menu category
feenkcom/Brick@efc4e6 by Aliaksei Syrel
[#4817] add settings around cursor blinking
feenkcom/Brick@e20447 by Aliaksei Syrel
[#4817] text editor cursor blinks
j-brant/SmaCC@58181b by John Brant
[#29] elixir prefer binary op over unary op when both are possible
feenkcom/gt4pharo@7707c5 by Andrei Chi�
Add examples for getting the timestamp of a change record [#4827]
feenkcom/gt4pharo@1d97a1 by Alistair Grant
Behavior>>#compileAllFrom:announcing: update comment
Pharo have implemented a different fix for this in Pharo 14, so this should be reviewed as part of the upgrade to Pharo 14.
See pharo-project/pharo#18706
feenkcom/gt4git@fee2cc by Alistair Grant
Remove extensions that have been incorporated upstream:
- IceLibgitFiletreeLog>>#definitionFor:path:commit:
- IceLibgitTonelLog>>#definitionFor:path:commit:
abc753 by Andrei Chi�
Fix ChangeRecord>>#timeStamp [#4827]
5e08f1 by Alistair Grant
BaselineOfGToolkitPrerequisites>>#applyPatchForPharo12SystemDictionaryAtPut update comment
This is fixed upstream by pharo-project/pharo#18807.
Once we pick up that image BaselineOfGToolkitPrerequisites>>#applyPatchForPharo12SystemDictionaryAtPut should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR solves Issue#18598
My previous attempt: PR#18618 got too complicated because I found new bugs during its resolution (see here), so I decided to divide it in 2 different PRs.
Description of the Solution
As @akgrant43 pointed out in Issue #18598, Epicea was not logging method creation entries when duplicating classes, because the announcer was silenced in
Behavior>>#recompile:from:.My solution preserves the silence for method recompilations, but ensures that method compilations always announce their code changes.
As a result,
Behavior>>compileAllFrom:now announces its changes. This is correct, since it is only used when copying methods from an existing class into a new one—the exact scenario that was failing in the original issue.