New Rule 22-44 #1829
Open
New Rule 22-44 #1829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claperle
commented
Sep 24, 2025
docs/section22/Rule22-44.md
Outdated
| - Note to RDS team - if there is missing output data the outcome is also UNDETERMINED with a message indicating that the modeled performance curves could not be evaluated. | ||
|
|
||
| **Notes:** | ||
| 1. Can we add chiller.design_leaving_condenser_temperature to th schema? |
There was a problem hiding this comment.
Add as public comment when it goes for public review
claperle
commented
Sep 24, 2025
docs/section22/Rule22-44.md
Outdated
|
|
||
| **Notes:** | ||
| 1. Can we add chiller.design_leaving_condenser_temperature to th schema? | ||
| 2. Update is_chiller_performance_app_j() to take in which table to reference? |
There was a problem hiding this comment.
Update to take in chiller and table reference and update accordingly. Jackson agrees.
There was a problem hiding this comment.
I think Jackson will incorporate since he is workign on this function
claperle
commented
Sep 24, 2025
claperle
commented
Sep 29, 2025
docs/section22/Rule22-44.md
Outdated
| - Note to RDS team - if there is missing output data the outcome is also UNDETERMINED with a message indicating that the modeled performance curves could not be evaluated. | ||
|
|
||
| **Notes:** | ||
| 1. Can we add chiller.design_leaving_condenser_temperature to the schema? |
There was a problem hiding this comment.
Add as public comment
JacksonJ-KC
reviewed
Sep 30, 2025
docs/section22/Rule22-44.md
Outdated
|
|
||
| - **Check 1:** Get B-RMD system types: `baseline_hvac_system_dict = get_baseline_system_types(B-RMD)` | ||
|
|
||
| - Check if B-RMD is modeled with at least one air-side system that is Type-7, 8, 11.1, 11.2, 12, 13, 7b, 8b, 11b, 12b, i.e. with air-side system served by chiller(s), continue to the next applicability check: `if any(sys_type in baseline_hvac_system_dict.keys() for sys_type in ["SYS-7", "SYS-8", "SYS-11.1", "SYS-11.2", "SYS-12", "SYS-13", "SYS-7B", "SYS-8B", "SYS-11B", "SYS-12B"]): NEXT_APPLICABILITY_CHECK` |
There was a problem hiding this comment.
Applicability should just be whether the proposed has a chiller right?
There was a problem hiding this comment.
Yeah, whether it has a proposed non process chiller. I updated accordingly.
JacksonJ-KC
reviewed
Sep 30, 2025
docs/section22/Rule22-44.md
Outdated
|
|
||
| - Get primary and secondary loops for B-RMD: `primary_secondary_loop_dictionary = get_primary_secondary_loops_dict(B_RMD)` | ||
|
|
||
| - For each chiller in B_RMD: `for chiller in B_RMD...chillers:` |
JacksonJ-KC
reviewed
Sep 30, 2025
docs/section22/Rule22-44.md
Outdated
|
|
||
| - Check if B-RMD is modeled with at least one air-side system that is Type-7, 8, 11.1, 11.2, 12, 13, 7b, 8b, 11b, 12b, i.e. with air-side system served by chiller(s), continue to the next applicability check: `if any(sys_type in baseline_hvac_system_dict.keys() for sys_type in ["SYS-7", "SYS-8", "SYS-11.1", "SYS-11.2", "SYS-12", "SYS-13", "SYS-7B", "SYS-8B", "SYS-11B", "SYS-12B"]): NEXT_APPLICABILITY_CHECK` | ||
|
|
||
| - Else, rule is not applicable to B-RMD: `else: RULE_NOT_APPLICABLE` |
JacksonJ-KC
reviewed
Sep 30, 2025
docs/section22/Rule22-44.md
Outdated
|
|
||
| - Else, rule is not applicable to B-RMD: `else: RULE_NOT_APPLICABLE` | ||
|
|
||
| - Get primary and secondary loops for B-RMD: `primary_secondary_loop_dictionary = get_primary_secondary_loops_dict(B_RMD)` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in progress but creating a pull request so it does not get lost.