-
Notifications
You must be signed in to change notification settings - Fork 6
RDS/CML/Rule 22-44 #1829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
claperle
wants to merge
6
commits into
feature/ashrae-9012022
Choose a base branch
from
RDS/CML/22-44
base: feature/ashrae-9012022
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+59
−0
Open
RDS/CML/Rule 22-44 #1829
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
afe8568
New RDS, in progress.
claperle 3c1e271
New RDS, in progress.
claperle a96727c
Update Rule22-44.md
claperle 841e685
Updated for proposed as opposed to previous baseline logic.
claperle 5b4f8a0
Updated for proposed as opposed to previous baseline logic.
claperle 18629e7
ruleset function updates
JacksonJ-KC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # CHW & CW - Rule 22-44 | ||
|
|
||
| **Rule ID:** 22-44 | ||
| **Rule Description:** Where part-load performance of chillers in the proposed design is not available, and the design temperature across the condenser is 10°F, the performance curves in Normative Appendix J, as referenced in Table J-1, shall be modeled for the specified chiller. | ||
| **Rule Assertion:** Proposed RMD = expected value | ||
| **Appendix G Section:** Table G3.1 #10b Proposed Column | ||
|
|
||
| **Mandatory Rule:** True | ||
| **Evaluation Context:** Each Chiller | ||
| **Table Lookup:** 90.1 Appendix J Table J-4 | ||
| **Function Call:** | ||
| 1. is_chiller_performance_app_j() | ||
|
|
||
| ## Applicability Check: | ||
|
|
||
| - **Check 1:** Get B-RMD system types: `baseline_hvac_system_dict = get_baseline_system_types(B-RMD)` | ||
|
|
||
| - Check if B-RMD is modeled with at least one air-side system that is Type-7, 8, 11.1, 11.2, 12, 13, 7b, 8b, 11b, 12b, i.e. with air-side system served by chiller(s), continue to the next applicability check: `if any(sys_type in baseline_hvac_system_dict.keys() for sys_type in ["SYS-7", "SYS-8", "SYS-11.1", "SYS-11.2", "SYS-12", "SYS-13", "SYS-7B", "SYS-8B", "SYS-11B", "SYS-12B"]): NEXT_APPLICABILITY_CHECK` | ||
|
|
||
| - Else, rule is not applicable to B-RMD: `else: RULE_NOT_APPLICABLE` | ||
JacksonJ-KC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| - Get primary and secondary loops for B-RMD: `primary_secondary_loop_dictionary = get_primary_secondary_loops_dict(B_RMD)` | ||
JacksonJ-KC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| - For each chiller in B_RMD: `for chiller in B_RMD...chillers:` | ||
JacksonJ-KC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| - Store the design temperature across the condenser: `design_temperature_across_condenser = chiller.design_leaving_condenser_temperature - chiiler.design_entering_condenser_temperature` | ||
| - Check if chiller is connected to a primary chilled water loop that serves HVAC systems: `if chiller.cooling_loop.id in primary_secondary_loop_dictionary: CHECK_RULE_LOGIC` | ||
|
|
||
| **Rule Assertion:** | ||
| - Case 1: all lists of missing or non-matching validation points have a length of zero and the design temperature across the condenser is 10F: PASS: `if is_chiller_performance_app_j(chiller) and design_temperature_across_condenser == 10: PASS` | ||
| - Case 2: all lists of missing or non-matching validation points have a length of zero and the design temperature across the condenser is NOT 10F: `elif is_chiller_performance_app_j(chiller) and design_temperature_across_condenser != 10: FAIL` | ||
| - Case 3: else when all output data is present for the chiller UNDETERMINED: `else: UNDETERMINED and raise_message "FAIL unless manufacturer full- and part-load data is provided to support the modeled curves.` | ||
| - Note to RDS team - if there is missing output data the outcome is also UNDETERMINED with a message indicating that the modeled performance curves could not be evaluated. | ||
|
|
||
| **Notes:** | ||
| 1. Can we add chiller.design_leaving_condenser_temperature to th schema? | ||
JacksonJ-KC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 2. Update is_chiller_performance_app_j() to take in which table to reference? | ||
JacksonJ-KC marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 3. This rule needs to be added to the rule Workbook | ||
claperle marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
|
|
||
| **[Back](../_toc.md)** | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.