Skip to content

Conversation

claperle
Copy link
Collaborator

Checks if lighting and misc were modeled identically across base and proposed for plenums, crawl spaces, and interstitial spaces. This also needs to be added to 90.1 2019.

**Notes:**
1. Could the interiorlighting and misc objects have different IDS across the baseline and proposed, if so how do we match them up ?
2. Need to add this rule to Workbook.
3. Need to also add this to 90.1 2019.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weili will make sure it goes to both when doing the merge

- Case 2: if a mismatch was found then FAIL: `else: FAIL and raise_message "It is expected that lighting and miscelleneous equipment would be modeled identically across the baseline and proposed for plenums, crawl spaces, and interstitial spaces. A mismatch was observed for <include space id and the mismatches observed>" `

**Notes:**
1. Could the interiorlighting and misc objects have different IDS across the baseline and proposed, if so how do we match them up ?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team will review

@weilixu
Copy link
Collaborator

weilixu commented Sep 29, 2025

In 2022, the rule 6-10 is about retail lighting in the baseline model #1780
There seem to be some misalignment in the numbering between 90.1 2019 and 90.1 2022, could you check the number and update accordingly?
As far as I can tell, right now, 90.1 2019 does not have 6-10 rule.

@claperle
Copy link
Collaborator Author

In 2022, the rule 6-10 is about retail lighting in the baseline model #1780 There seem to be some misalignment in the numbering between 90.1 2019 and 90.1 2022, could you check the number and update accordingly? As far as I can tell, right now, 90.1 2019 does not have 6-10 rule.

@weilixu Just a tracking communication error. This should be 6-11 but it should be in both 2019 and 2022, how should the numbering be handled since the retail 6-10 is only in 90.1 2022.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants