-
Notifications
You must be signed in to change notification settings - Fork 6
New Rule 6-10 #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
claperle
wants to merge
6
commits into
feature/ashrae-9012022
Choose a base branch
from
RDS/CML/6-10
base: feature/ashrae-9012022
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New Rule 6-10 #1830
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f0dde3f
New RDS for assessing lighting and misc matching for plenums, interst…
claperle 9e45942
New RDS for assessing lighting and misc matching for plenums, interst…
claperle b4c1865
Update Rule6-10.md
claperle 3df2783
Update Rule6-10.md
claperle 3ab5e2e
Update Rule6-10.md
claperle 4ce39c3
Update Rule6-10.md
claperle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
|
||
# Lighting - Rule 6-10 | ||
|
||
**Rule ID:** 6-10 | ||
**Rule Description:** Lighting and miscellaneous equipment loads and schedules are modeled identically across the baseline and proposed for plenums, crawl spaces, and interstitial spaces. | ||
**Rule Assertion:** Proposed RMD = Baseline RMD | ||
**Appendix G Section:** Table G3.1 #1 Baseline Column | ||
**Appendix G Section Reference:** None | ||
|
||
**Applicability:** Spaces with a function defined as plenum, crawl space, or interstitial space. | ||
**Applicability Checks:** | ||
|
||
1. Spaces with a function defined as plenum, crawl space, or interstitial space. | ||
|
||
**Manual Check:** None | ||
**Evaluation Context:** Each Space | ||
**Data Lookup:** None | ||
|
||
**Function Call:** | ||
|
||
1. compare_schedules() | ||
2. match_data_element() | ||
|
||
## Rule Logic: | ||
|
||
- For each space in the proposed RMD: `for space_p in P_RMD...Space:` | ||
|
||
- **Applicability Check:** `if space_p.function not in [PLENUM, CRAWL_SPACE, INTERSTITIAL_SPACE]:` | ||
- RULE_NOT_APPLICABLE: `continue` | ||
|
||
- **Rule Logic:** | ||
- Create boolean to track mismatch between baseline and proposed: `mismatch = False` | ||
- Match baseline space: `space_b = match_data_element(B_RMD, Spaces, space_p.name)` | ||
- If space not found then mismatch is TRUE: `if not space_b:` | ||
- mismatch = True: `mismatch = True` | ||
- No match found: `continue` | ||
- Index baseline lighting by ID: `baseline_lighting = {obj.id: obj for obj in space_b.interior_lighting}` | ||
- For each interior lighting object associated with space_p, compare each to baseline lighting object: `for lighting_p in space_p.interior_lighting:` | ||
- Get analogous baseline lighting object: `lighting_b = baseline_lighting.get(lighting_p.id)` | ||
- If lighting_b not found then mismatch is TRUE: `if not lighting_b:` | ||
- mismatch = True: `mismatch = True` | ||
- No match found: `continue` | ||
- Compare attributes: ` if ( | ||
lighting_b.purpose_type != lighting_p.purpose_type or | ||
lighting_b.power_per_area != lighting_p.power_per_area or | ||
lighting_b.occupancy_control_type != lighting_p.occupancy_control_type or | ||
lighting_b.daylighting_control_type != lighting_p.daylighting_control_type or | ||
not compare_schedules( | ||
lighting_p.lighting_multiplier_schedule, | ||
lighting_b.lighting_multiplier_schedule, | ||
method="1 for all 8760" | ||
) | ||
):` | ||
- Mismatch equals true: `mismatch = True` | ||
- Index baseline misc by ID: `baseline_misc = {obj.id: obj for obj in space_b.miscellaneous_equipment}` | ||
- For each misc equipment object associated with space_p, compare each to baseline misc object: `for misc_p in space_p.miscellaneous_equipment:` | ||
- Get analogous baseline misc object: `misc_b = baseline_misc.get(misc_p.id)` | ||
- If misc_b not found then mismatch is TRUE: `if not misc_b:` | ||
- mismatch = True: `mismatch = True` | ||
- No match found: `continue` | ||
- Compare attributes: ` if ( | ||
misc_b.energy_type != misc_p.energy_type or | ||
misc_b.power != misc_p.power or | ||
misc_b.sensible_fraction != misc_p.sensible_fraction or misc_b.latent_fraction != misc_p.latent_fraction or | ||
misc_b.remaining_fraction_to_loop != misc_p.remaining_fraction_to_loop or | ||
misc_b.energy_from_loop != misc_p.energy_from_loop or | ||
misc_b.type != misc_p.type or | ||
misc_b.automatic_controlled_percentage != misc_p.automatic_controlled_percentage or | ||
not compare_schedules( | ||
misc_p.multiplier_schedule, | ||
misc_b.multiplier_schedule, | ||
method="1 for all 8760" | ||
) | ||
):` | ||
- Mismatch equals true: `mismatch = True` | ||
|
||
**Rule Assertion:** | ||
- Case 1: If no mismatch was found then PASS: `if not mismatch: PASS` | ||
- Case 2: if a mismatch was found then FAIL: `else: FAIL and raise_message "It is expected that lighting and miscelleneous equipment would be modeled identically across the baseline and proposed for plenums, crawl spaces, and interstitial spaces. A mismatch was observed for <include space id and the mismatches observed>" ` | ||
|
||
**Notes:** | ||
1. Could the interiorlighting and misc objects have different IDS across the baseline and proposed, if so how do we match them up ? | ||
2. Need to add this rule to Workbook. | ||
claperle marked this conversation as resolved.
Show resolved
Hide resolved
|
||
3. Need to also add this to 90.1 2019. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Weili will make sure it goes to both when doing the merge |
||
|
||
**[Back](../_toc.md)** |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Team will review