make matplotlib an optional dependency #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kandersolar
reviewed
Sep 4, 2025
There was a problem hiding this comment.
Thanks @kurt-rhee! It would have been nice for the code formatting to be done separately, but no need to revert it now.
| ] | ||
| plot = ["matplotlib"] | ||
| test = ["pytest>=3.2.1", "pytest-mock>=1.10.0", "mock", "matplotlib"] | ||
| doc = [ |
There was a problem hiding this comment.
Please also add matplotlib to doc. It happens to gets pulled in anyway by ipykernel, but better to require it directly.
|
|
||
| Maintenance | ||
| ----------- | ||
| * Matplotlib is now an optional dependency. (:issue:`31`) |
There was a problem hiding this comment.
Please move it to v1.6.1, which hasn't been released yet
|
|
||
| Please note that the plot is generated using matplotlib, which is | ||
| not included in the default dependencies, it can be installed | ||
| using `pip install solarfactors[plot]` |
There was a problem hiding this comment.
GitHub is displaying this in the same paragraph as line 119, making it flow a little poorly. Maybe edit the code block to something like:
# Plot pvarray shapely geometries (needs matplotlib: pip install solarfactors[plot])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.