-
Couldn't load subscription status.
- Fork 9
make matplotlib an optional dependency #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kurt-rhee
wants to merge
2
commits into
pvlib:main
Choose a base branch
from
kurt-rhee:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| .. _whatsnew_162: | ||
|
|
||
| v1.6.2 (??) | ||
| ========== | ||
|
|
||
|
|
||
| Maintenance | ||
| ----------- | ||
| * Matplotlib is now an optional dependency. (:issue:`31`) | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please move it to v1.6.1, which hasn't been released yet |
||
|
|
||
|
|
||
| Documentation | ||
| ------------- | ||
|
|
||
| Contributors | ||
| ------------ | ||
| * Kurt Rhee (:ghuser:`kurt-rhee`) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| """Utility module for handling optional dependencies for plotting functionality.""" | ||
|
|
||
| import functools | ||
|
|
||
|
|
||
| def _matplotlib_import_error_message(): | ||
| """Generate helpful error message for missing matplotlib.""" | ||
| return ( | ||
| "matplotlib is required for plotting functionality. " | ||
| "Install it using one of the following methods:\n" | ||
| " pip install solarfactors[plot]\n" | ||
| " pip install matplotlib\n" | ||
| " conda install matplotlib" | ||
| ) | ||
|
|
||
|
|
||
| def _check_matplotlib(): | ||
| """ | ||
| Check if matplotlib is available and raise ImportError if not. | ||
| """ | ||
| try: | ||
| import matplotlib # noqa: F401 | ||
|
|
||
| return True | ||
| except ImportError: | ||
| raise ImportError(_matplotlib_import_error_message()) | ||
|
|
||
|
|
||
| def requires_matplotlib(func): | ||
| """Decorator to check for matplotlib availability before executing | ||
| plotting functions. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| func : callable | ||
| Function that requires matplotlib | ||
|
|
||
| Returns | ||
| ------- | ||
| callable | ||
| Wrapped function that checks for matplotlib before execution | ||
| """ | ||
|
|
||
| @functools.wraps(func) | ||
| def wrapper(*args, **kwargs): | ||
| _check_matplotlib() | ||
| return func(*args, **kwargs) | ||
|
|
||
| return wrapper | ||
|
|
||
|
|
||
| def optional_matplotlib_import(): | ||
| """Import matplotlib.pyplot with optional handling. | ||
|
|
||
| Returns | ||
| ------- | ||
| module or None | ||
| matplotlib.pyplot module if available, None otherwise | ||
|
|
||
| Raises | ||
| ------ | ||
| ImportError | ||
| If matplotlib is not available with helpful installation message | ||
| """ | ||
| _check_matplotlib() | ||
| import matplotlib.pyplot as plt # noqa: F401 | ||
|
|
||
| return plt |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub is displaying this in the same paragraph as line 119, making it flow a little poorly. Maybe edit the code block to something like: