-
-
Notifications
You must be signed in to change notification settings - Fork 683
1D+ sensitivities error with IDAKLU output_variables #5118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1D+ sensitivities error with IDAKLU output_variables #5118
Conversation
Requires: pybamm-team/pybammsolvers#52 |
@pipliggins |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5118 +/- ##
========================================
Coverage 98.80% 98.80%
========================================
Files 320 320
Lines 27034 27034
========================================
Hits 26711 26711
Misses 323 323 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@MarcBerliner Yes! I'll mark it ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
When using
output_variables
, sensitivity calculations were incorrect for 1D+ variables, and all variables which followed them in theoutput_variables
list. This is a bug in the C++ code stored in pybammsolvers so a seperate PR will be made there, this one just adds tests to pybamm that catch the bug and should pass once the solvers package is fixed and updated.Fixes #5058
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)