Incomplete sensitivities for 1D+ output_variables #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinjrobins
requested changes
Jul 16, 2025
There was a problem hiding this comment.
thanks @pipliggins for fixing this! Looking at the indexing is making my head hurt. While its in your head, can you write some comments detailing what this function does and how the indexing works?
martinjrobins
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When solving with
output_variables& sensitivities, sensitivities for variables >= 1D only ever wrote to row 0 of each variable's slice (indexing withdvar_kgives the variable index, not the internal row). This also had the effect of offsetting the index locations of 0D variables further down theoutput_variablelist, causing their associated sensitivities to be incorrect once the sensitivity array is reshaped and passed back to python.This fix adds an inner row loop to store the entire array for non-scalar variables.
Associated pybamm issue: #5058 and PR with test for this behaviour: #5118