Do not fail connect if ap is missing in pdsc #1801
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ails, just don't set it For devices that have 'hidden' cores, there will not be a <processor /> correctly describing the AP entry. So, if we cannot find the processor, just let it go nameless. This fixes pyocd#1800, pyocd#1678, pyocd#1637
|
With this change, I have control of both cores; Connected to PIC32CK2051SG01144 [Halted]: 020057703RYN000336
pyocd> core
Core 0 (Cortex-M33) is selected
pyocd> status
Core 0 (Cortex-M33): Halted [Secure]
Core 1 (None): Running
pyocd> core 1
Selected core 1 (None) (AHB-AP#1)
pyocd> halt
0159996 D halting core 1 [cortex_m]
Successfully halted device
pyocd> status
Core 0 (Cortex-M33): Halted [Secure]
Core 1 (None): HaltedI guess in stead of Connected to PIC32CK2051SG01144 [Halted]: 020057703RYN000336
pyocd> status
Core 0 (Cortex-M33): Halted [Secure]
Core 1 (ARMv6M): HaltedThoughts? |
… name of the architecture of the core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to map the
pnameof theprocessor, don't fail if the process is not described in the pdsc file.This fixes #1800, #1678, #1637