-
Notifications
You must be signed in to change notification settings - Fork 62
Add install instructions for Windows GPU #888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If you are building FFmpeg from source you can follow Nvidia's guide to | ||
configuring and installing FFmpeg with NVDEC support | ||
[here](https://docs.nvidia.com/video-technologies/video-codec-sdk/12.0/ffmpeg-with-nvidia-gpu/index.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by, I don't want to bother readers about installing FFmpeg from source, they shouldn't need to and it shouldn't be in the "entry point" install instructions anyway.
README.md
Outdated
Note that without passing in the `--index-url` parameter, `pip` installs | ||
the CPU-only version of TorchCodec. | ||
```bash | ||
conda install torchcodec -c conda-forge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda install torchcodec -c conda-forge | |
conda install torchcodec -c conda-forge |
this should indeed install torchcodec with cuda
support on a machine with cuda support, but it may silently install the cpu version on a machine without cuda support. If you want to make sure that the cuda version is installed, and an error is printed in case it is not possible to install, you need to:
conda install torchcodec -c conda-forge | |
conda install torchcodec=*=*cuda* -c conda-forge |
As a meta-comment on this, I do not monitor all the issues in the torchcodec repo, so if there are users experiencing problems with the conda-forge packages, feel free to ping me or to redirect them to open an issue at https://github.com/conda-forge/torchcodec-feedstock/issues . |
Also, I am not sure if the instructions in the current form actually works. In point 1, it is described how to install PyTorch with pip, but that would not work out of the box (due to different ABIs) with the conda-forge
and this command will automatically install the approprite cuda, ffmpeg and pytorch version via conda-forge. |
@traversaro, thank you for making this happen! |
Thanks for for all the work on |
Thanks to @traversaro , Windows GPU support is available via
conda-forge
.