Skip to content

Conversation

the-mikedavis
Copy link
Collaborator

@the-mikedavis the-mikedavis commented May 12, 2025

Proposed Changes

This is a minor change to remove the connection limit and current active count from health checks which returned them (introduced in #13879).

Returning the connection limit and active count are not really necessary for these checks. Instead of returning them in the response to the health check we log a warning when the connection limit is exceeded.

Connects #13782

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Returning the connection limit and active count are not really necessary
for these checks. Instead of returning them in the response to the
health check we log a warning when the connection limit is exceeded.
@the-mikedavis the-mikedavis self-assigned this May 12, 2025
@the-mikedavis the-mikedavis added this to the 4.2.0 milestone May 13, 2025
@the-mikedavis the-mikedavis merged commit 3e1fa7b into main May 13, 2025
271 of 272 checks passed
@the-mikedavis the-mikedavis deleted the md/scrub-health-check-returns branch May 13, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant