Skip to content

Add body param in delete method #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add body param in delete method #278

wants to merge 1 commit into from

Conversation

@SushilMallRC
Copy link
Contributor

@SushilMallRC SushilMallRC commented Oct 7, 2025 •
edited
Loading

Change log

Support HTTP DELETE with a body params.

@coveralls
Copy link

Coverage Status

coverage: 92.809%. remained the same
when pulling f8cec37 on deleteWithBodyParam
into f9b27bb on master.

embbnux
embbnux reviewed Oct 16, 2025
View reviewed changes
sdk/src/SDK.ts
/* istanbul ignore next */
public delete = async (url, query?, options?: SendOptions): Promise<Response> =>
this.platform().send({method: 'DELETE', url, query, ...options});
public delete = async (url, body?, query?, options?: SendOptions): Promise<Response> =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a break change. We need to update docs too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@embbnux embbnux embbnux approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SushilMallRC @coveralls @embbnux