Add body param in delete method

sdk/src/SDK.ts

@@ -122,8 +122,8 @@ export class SDK {
         this.platform().send({method: 'PATCH', url, query, body, ...options});
 
     /* istanbul ignore next */
-    public delete = async (url, query?, options?: SendOptions): Promise<Response> =>
-        this.platform().send({method: 'DELETE', url, query, ...options});
+    public delete = async (url, body?, query?, options?: SendOptions): Promise<Response> =>
+        this.platform().send({method: 'DELETE', url, query, body, ...options});
 
     /* istanbul ignore next */
     public login = async (options: LoginOptions): Promise<Response> => this.platform().login(options);

sdk/src/platform/Platform-spec.ts

@@ -705,6 +705,57 @@
                 expect(request.headers.get('x-user-agent')).toContain('TestAgent');
             }),
         );
+
+        it(
+            'DELETE without body',
+            asyncTest(async sdk => {
+                const platform = sdk.platform();
+                const client = sdk.client();
+                const path = `/restapi/v1.0/foo/delete-no-body`;
+
+                apiCall('DELETE', path, {ok: true});
+
+                let request;
+                client.on(client.events.requestSuccess, (_, r) => {
+                    request = r;
+                });
+
+                const res = await platform.delete(path);
+                const json = await res.json();
+
+                expect(json.ok).toEqual(true);
+                expect(request.method).toEqual('DELETE');
+                expect(request.url).toEqual(`http://whatever${path}`);
+                expect(request.headers.get('content-type')).toContain('application/json');
+                expect(request['originalBody']).toEqual(undefined);
+            }),
+        );
+
+        it(
+            'DELETE with JSON body',
+            asyncTest(async sdk => {
+                const platform = sdk.platform();
+                const client = sdk.client();
+                const path = `/restapi/v1.0/foo/delete-with-body`;
+
+                apiCall('DELETE', path, {ok: true});
+
+                let request;
+                client.on(client.events.requestSuccess, (_, r) => {
+                    request = r;
+                });
+
+                const payload = {reason: 'cleanup', force: true};
+                const res = await platform.delete(path, payload);
+                const json = await res.json();
+
+                expect(json.ok).toEqual(true);
+                expect(request.method).toEqual('DELETE');
+                expect(request.url).toEqual(`http://whatever${path}`);
+                expect(request.headers.get('content-type')).toContain('application/json');
+                expect(request['originalBody']).toEqual(JSON.stringify(payload));
+            }),
+        );
     });
 
     describe('createUrl', () => {
@@ -973,7 +1024,7 @@
                 const openSpy = spy(() => null);
 
                 window.open = openSpy;
                 await expectThrows(async () => {
                     await platform.loginWindow({
                         url: 'foo',
                         origin: 'foo',
@@ -996,7 +1047,7 @@
                     openWindow.closed = true;
                 }, 3000);
 
                 await expectThrows(async () => {
                     await platform.loginWindow({
                         url: 'foo',
                         origin: 'foo',
@@ -1099,7 +1150,7 @@
         );
     });
 
     describe('discovery initial', () => {
         let sdk;
 
         beforeEach(() => {
@@ -1240,7 +1291,7 @@
             expect(await platform.discovery().externalDataExpired()).toEqual(false);
         });
 
         it('should fetch external discovery when login with discovery_uri and token_uri when discoveryInitPromise finished', async () => {
             // mock
             const initialDiscoveryData = getInitialDiscoveryMockData();
             const externalDiscoveryData = getExternalDiscoveryMockData();

sdk/src/platform/Platform.ts

@@ -362,7 +362,7 @@
     }: LoginWindowOptions): Promise<LoginOptions> {
         // clear check last timeout when user open loginWindow twice to avoid leak
         this._clearLoginWindowCheckTimeout();
         return new Promise((resolve, reject) => {
             if (typeof window === 'undefined') {throw new Error('This method can be used only in browser');}
 
             if (!url) {throw new Error('Missing mandatory URL parameter');}
@@ -454,7 +454,7 @@
         }
     }
 
     public async login({
         username,
         password,
         extension = '',
@@ -574,7 +574,7 @@
         return {tokenEndpoint, discoveryEndpoint};
     }
 
     private async _refresh(): Promise<Response> {
         try {
             this.emit(this.events.beforeRefresh);
 
@@ -717,12 +717,12 @@
         return request;
     }
 
     public async sendRequest(request: Request, options: SendOptions = {}): Promise<Response> {
         try {
             request = await this.inflateRequest(request, options);
             return await this._client.sendRequest(request);
         } catch (e) {
             let {retry, handleRateLimit} = options;
 
             // Guard is for errors that come from polling
             if (!e.response || retry) {throw e;}
@@ -811,8 +811,8 @@
         return this.send({method: 'PATCH', url, query, body, ...options});
     }
 
-    public async delete(url, query?, options?: SendOptions): Promise<Response> {
-        return this.send({method: 'DELETE', url, query, ...options});
+    public async delete(url, body?, query?, options?: SendOptions): Promise<Response> {
+        return this.send({method: 'DELETE', url, query, body, ...options});
     }
 
     public async ensureLoggedIn(): Promise<Response | null> {