Skip to content

Conversation

fujitatomoya
Copy link
Contributor

Description

Fixes #885

Is this user-facing behavior change?

No

Did you use Generative AI?

No

Additional Information

@fujitatomoya fujitatomoya requested a review from Copilot August 23, 2025 07:38
@fujitatomoya fujitatomoya self-assigned this Aug 23, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a warning message to inform users when rosidl_adapter is not available but non-IDL interface files are provided, helping them understand why their build might fail and how to resolve the issue.

  • Adds a warning message in the rosidl_generate_interfaces macro when rosidl_adapter is not found
  • Provides clear guidance on how to resolve the issue by adding the required package dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@fujitatomoya
Copy link
Contributor Author

fujitatomoya commented Aug 23, 2025

Pulls: #886
Gist: https://gist.githubusercontent.com/fujitatomoya/fdd51a657e3e7a5b7cbee9428faec2bf/raw/afbf7df8e61ab7ae002ecd54d0162b005a8c730f/ros2.repos
BUILD args: --packages-above-and-dependencies rosidl_cmake
TEST args: --packages-above rosidl_cmake
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16784

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link

@GuillaumeDua GuillaumeDua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , but perhaps there's other generators and/or a specific generator API worth mentioning here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing and misleading rosidl_write_generator_arguments error
2 participants