feat: Support memory profiling with dhat #20927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
dhat
branch
3 times, most recently
from
7a4a834 to
e96b16b
Compare
Member
|
I think I've tried this once and analysis-stats never finished, is it still the same? |
Contributor
Author
|
I did not check analysis-stats, but it does succeed cache priming, although it's very slow. |
ChayimFriedman2
force-pushed
the
dhat
branch
2 times, most recently
from
dab5725 to
8d8a711
Compare
Unfortunately, this requires a custom build of r-a, and it's quite slow.
Closed
| pub(crate) fn handle_memory_usage(state: &mut GlobalState, _: ()) -> anyhow::Result<String> { | ||
| pub(crate) fn handle_memory_usage(_state: &mut GlobalState, _: ()) -> anyhow::Result<String> { | ||
| let _p = tracing::info_span!("handle_memory_usage").entered(); | ||
| let mem = state.analysis_host.per_query_memory_usage(); |
Member
There was a problem hiding this comment.
Though the actual implementation of this has been commented out while salsa migration, won't there be a chance it to be re-implemented?
Contributor
Author
There was a problem hiding this comment.
I do hope to also have a profiling option that does not require a custom build, but I imagine then this command will collect both.
ShoyuVanilla
approved these changes
Oct 31, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this requires a custom build of r-a, and it's quite slow.