-
Notifications
You must be signed in to change notification settings - Fork 133
examples: add signing new cert using existing ca pem files #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iamjpotts
wants to merge
1
commit into
rustls:main
Choose a base branch
from
iamjpotts:jp/sign-server-with-intermediate-pems
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
examples: add signing new cert using existing ca pem files #379
iamjpotts
wants to merge
1
commit into
rustls:main
from
iamjpotts:jp/sign-server-with-intermediate-pems
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Sep 22, 2025
I think this is definitely better than #378. |
djc
reviewed
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash your changes into a single commit.
e33ee51
to
135b0e2
Compare
djc
approved these changes
Sep 24, 2025
Open
135b0e2
to
6b85378
Compare
Rebased; no changes. |
6b85378
to
9e4fa69
Compare
cpu
approved these changes
Sep 26, 2025
9e4fa69
to
5f19737
Compare
Signed-off-by: Joshua Potts <[email protected]>
5f19737
to
ab22e1b
Compare
If #381 is merged first, this will need a rebase and a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example based on
0.14
that reads an existing certificate authority (root or intermediate) from itsPEM
files into anIssuer
and generates and signs a new leaf/server certificate using that certificate authority.Alternative to #378.