Skip to content

Conversation

iamjpotts
Copy link
Contributor

Enable nightly formatting option group_imports = "StdExternalCrate".

#379 (comment)

@iamjpotts
Copy link
Contributor Author

It is not clear to me why the github ui is expecting a Format & clippy job. That job was split into two - a Clippy job and a Format (unstable) job.

.rustfmt.toml Outdated
hard_tabs = true
match_block_trailing_comma = true

unstable_features = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do it this way -- instead, refer to the rustls workflow I linked to in your other PR which has two separate rustfmt configs and makes sure that the default config can still run with stable rustfmt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

I've also added imports_granularity = "Module" since that was in the linked workflow.

It is not clear to me why the github ui is expecting a Format & clippy job.

This also appears resolved (note that I also renamed the workflow job from fmt to fmt-unstable)

@iamjpotts iamjpotts force-pushed the jp/cargo-fmt-group-imports branch 2 times, most recently from a8a15c5 to 251bb2d Compare September 28, 2025 17:50
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: Joshua Potts <[email protected]>
@iamjpotts iamjpotts force-pushed the jp/cargo-fmt-group-imports branch from 251bb2d to 96355f6 Compare October 1, 2025 01:22
@iamjpotts
Copy link
Contributor Author

If #379 is merged first, this will need a rebase and another cargo fmt run applied to it.

@djc djc requested a review from est31 October 1, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants