-
Notifications
You must be signed in to change notification settings - Fork 133
Group imports #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Group imports #381
Conversation
de4f8d2
to
a151bc4
Compare
It is not clear to me why the github ui is expecting a |
.rustfmt.toml
Outdated
hard_tabs = true | ||
match_block_trailing_comma = true | ||
|
||
unstable_features = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should do it this way -- instead, refer to the rustls workflow I linked to in your other PR which has two separate rustfmt configs and makes sure that the default config can still run with stable rustfmt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
I've also added imports_granularity = "Module"
since that was in the linked workflow.
It is not clear to me why the github ui is expecting a Format & clippy job.
This also appears resolved (note that I also renamed the workflow job from fmt
to fmt-unstable
)
a8a15c5
to
251bb2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Joshua Potts <[email protected]>
251bb2d
to
96355f6
Compare
If #379 is merged first, this will need a rebase and another |
Enable nightly formatting option
group_imports = "StdExternalCrate"
.#379 (comment)