refactor(semantic): Made enum more encapsulated. #8390
Conversation
|
This change is |
orizi
force-pushed
the
gt/orizi/09-11-refactor_semantic_split_semanticgroup_into_traits_per_item
branch
from
cb8148c to
e3d6aba
Compare
orizi
force-pushed
the
gt/orizi/09-11-refactor_semantic_made_enum_more_encapsulated
branch
from
aa54911 to
911e08d
Compare
orizi
changed the base branch from
gt/orizi/09-11-refactor_semantic_split_semanticgroup_into_traits_per_item
to
graphite-base/8390
orizi
force-pushed
the
gt/orizi/09-11-refactor_semantic_made_enum_more_encapsulated
branch
from
911e08d to
73fed59
Compare
orizi
force-pushed
the
graphite-base/8390
branch
from
e3d6aba to
2b9c280
Compare
There was a problem hiding this comment.
When you remove the sub-queries you change the calculations of "Has my input changed" (mostly affects LSP performance I assume). It might be better to make EnumDeclerationData / EnumDefinitionData tracked structs
@eytan-starkware reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @TomerStarkware)
There was a problem hiding this comment.
can't unfortunately - as it requires implementing Hash for basic elements that probably can't really implement hash.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @TomerStarkware)
There was a problem hiding this comment.
@eytan-starkware reviewed 1 of 3 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
There was a problem hiding this comment.
@TomerStarkware reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)
crates/cairo-lang-semantic/src/items/enm.rs line 43 at r1 (raw file):
/// Returns the declaration data of an enum. #[salsa::tracked(returns(ref))]
consider add a wrapper helper function to return as ref once
Code quote:
#[salsa::tracked(returns(ref))]
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)
crates/cairo-lang-semantic/src/items/enm.rs line 43 at r1 (raw file):
Previously, TomerStarkware wrote…
consider add a wrapper helper function to return as ref once
Rather not - too much function multiplicity as it is.
orizi
deleted the
gt/orizi/09-11-refactor_semantic_made_enum_more_encapsulated
branch
No description provided.