refactor(semantic): Better encapsulation of structs and extern-type queries. #8391
Conversation
|
This change is |
orizi
force-pushed
the
gt/orizi/09-11-refactor_semantic_better_encapsulation_of_structs_queries
branch
from
c80be6b to
b504176
Compare
orizi
force-pushed
the
gt/orizi/09-11-refactor_semantic_made_enum_more_encapsulated
branch
from
aa54911 to
911e08d
Compare
orizi
force-pushed
the
gt/orizi/09-11-refactor_semantic_better_encapsulation_of_structs_queries
branch
from
b504176 to
19d4677
Compare
orizi
force-pushed
the
gt/orizi/09-11-refactor_semantic_made_enum_more_encapsulated
branch
from
911e08d to
73fed59
Compare
There was a problem hiding this comment.
@eytan-starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)
-- commits line 5 at r2:
rebase
crates/cairo-lang-semantic/src/items/structure.rs line 32 at r2 (raw file):
mod test; // TODO(spapini): Check for bad recursive types - those that will fail in Sierra generation.
Do we no longer need to check for bad types?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eytan-starkware and @TomerStarkware)
crates/cairo-lang-semantic/src/items/structure.rs line 32 at r2 (raw file):
Previously, eytan-starkware wrote…
Do we no longer need to check for bad types?
was already done. leftover in a random place.
orizi
changed the base branch from
gt/orizi/09-11-refactor_semantic_made_enum_more_encapsulated
to
graphite-base/8391
orizi
force-pushed
the
graphite-base/8391
branch
from
73fed59 to
fe5e560
Compare
orizi
force-pushed
the
gt/orizi/09-11-refactor_semantic_better_encapsulation_of_structs_queries
branch
from
19d4677 to
f86597a
Compare
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @eytan-starkware and @TomerStarkware)
Previously, eytan-starkware wrote…
rebase
Done.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)
Previously, orizi wrote…
Done.
Not seeing it
orizi
changed the title
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @eytan-starkware and @TomerStarkware)
Previously, eytan-starkware wrote…
Not seeing it
renamed pr to be considered for both structure and extern type.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)
orizi
deleted the
gt/orizi/09-11-refactor_semantic_better_encapsulation_of_structs_queries
branch
refactor(semantic): Better encapsulation of structs queries.
refactor(semantic): Better extern-type encapsulation.