flow-control: Support let-else. #8399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2025
|
This change is |
orizi
approved these changes
Sep 14, 2025
There was a problem hiding this comment.
@orizi reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
liorgold2
force-pushed
the
pr/liorgold2/lior/flow-control/17f9f2da
branch
from
828b451 to
f7f922c
Compare
liorgold2
force-pushed
the
pr/liorgold2/lior/flow-control/fa4b6d4f
branch
from
3ac61ac to
bd898a8
Compare
orizi
approved these changes
Sep 14, 2025
There was a problem hiding this comment.
@orizi reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
liorgold2
force-pushed
the
pr/liorgold2/lior/flow-control/fa4b6d4f
branch
from
bd898a8 to
59f9d30
Compare
liorgold2
force-pushed
the
pr/liorgold2/lior/flow-control/17f9f2da
branch
from
f7f922c to
4171200
Compare
liorgold2
force-pushed
the
pr/liorgold2/lior/flow-control/fa4b6d4f
branch
from
59f9d30 to
3649ea8
Compare
liorgold2
force-pushed
the
pr/liorgold2/lior/flow-control/17f9f2da
branch
from
4171200 to
b69e366
Compare
commit-id:17f9f2da
liorgold2
force-pushed
the
pr/liorgold2/lior/flow-control/17f9f2da
branch
from
b69e366 to
d499daa
Compare
liorgold2
changed the base branch from
pr/liorgold2/lior/flow-control/fa4b6d4f
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack: