Skip to content

Conversation

liorgold2
Copy link
Collaborator

@liorgold2 liorgold2 commented Sep 13, 2025

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@liorgold2 liorgold2 requested a review from orizi September 14, 2025 10:00
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orizi reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion


crates/cairo-lang-lowering/src/lower/lower_match.rs line 157 at r1 (raw file):

/// Returns an option containing the PatternPath of the underscore pattern, if it exists.
fn get_underscore_pattern_path_and_mark_unreachable<'db>(

is the rest of the code still reachable as well?
this all sounds like things handled in the new flow.

Code quote:

get_underscore_pattern_path_and_mark_unreachable

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, all discussions resolved


crates/cairo-lang-lowering/src/lower/lower_match.rs line 157 at r1 (raw file):

Previously, orizi wrote…

is the rest of the code still reachable as well?
this all sounds like things handled in the new flow.

nm - i see further removals in later PRs.

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@orizi reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/17f9f2da branch from 828b451 to f7f922c Compare September 14, 2025 16:39
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/29416fcc branch 2 times, most recently from 4c8a729 to d4f4904 Compare September 14, 2025 21:11
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/17f9f2da branch from f7f922c to 4171200 Compare September 14, 2025 21:11
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/29416fcc branch from d4f4904 to b986e9b Compare September 14, 2025 21:15
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/17f9f2da branch 2 times, most recently from b69e366 to d499daa Compare September 15, 2025 07:10
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/29416fcc branch from b986e9b to 783644c Compare September 15, 2025 07:10
@liorgold2 liorgold2 changed the base branch from pr/liorgold2/lior/flow-control/17f9f2da to main September 15, 2025 10:59
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/29416fcc branch from 783644c to 8eab122 Compare September 15, 2025 10:59
@liorgold2 liorgold2 enabled auto-merge September 15, 2025 10:59
commit-id:29416fcc
@liorgold2 liorgold2 force-pushed the pr/liorgold2/lior/flow-control/29416fcc branch from 8eab122 to 94f1c4e Compare September 15, 2025 13:21
Copy link
Collaborator Author

@liorgold2 liorgold2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liorgold2 reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @liorgold2)

@liorgold2 liorgold2 added this pull request to the merge queue Sep 15, 2025
Merged via the queue into main with commit 203b8e1 Sep 15, 2025
51 checks passed
@orizi orizi deleted the pr/liorgold2/lior/flow-control/29416fcc branch September 28, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants