-
Notifications
You must be signed in to change notification settings - Fork 624
flow-control: Some cleanup. #8400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion
crates/cairo-lang-lowering/src/lower/lower_match.rs
line 157 at r1 (raw file):
/// Returns an option containing the PatternPath of the underscore pattern, if it exists. fn get_underscore_pattern_path_and_mark_unreachable<'db>(
is the rest of the code still reachable as well?
this all sounds like things handled in the new flow.
Code quote:
get_underscore_pattern_path_and_mark_unreachable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, all discussions resolved
crates/cairo-lang-lowering/src/lower/lower_match.rs
line 157 at r1 (raw file):
Previously, orizi wrote…
is the rest of the code still reachable as well?
this all sounds like things handled in the new flow.
nm - i see further removals in later PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orizi reviewed 1 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
828b451
to
f7f922c
Compare
4c8a729
to
d4f4904
Compare
f7f922c
to
4171200
Compare
d4f4904
to
b986e9b
Compare
b69e366
to
d499daa
Compare
b986e9b
to
783644c
Compare
783644c
to
8eab122
Compare
commit-id:29416fcc
8eab122
to
94f1c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liorgold2 reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @liorgold2)
Stack: