Req adapter: respect connect_timeout + recv_timeout client options for timeout #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stocks29
reviewed
Mar 29, 2025
| |> Keyword.get(:connect_options, []) | ||
| |> Keyword.get(:timeout, 30_000) | ||
|
|
||
| recv_timeout = Keyword.get(req.options, :recv_timeout, 15_000) |
There was a problem hiding this comment.
looks like the option for req is :receive_timeout not :recv_timeout
https://hexdocs.pm/req/Req.html#new/1
Suggested change
| recv_timeout = Keyword.get(req.options, :recv_timeout, 15_000) | |
| recv_timeout = Keyword.get(req.options, :receive_timeout, 15_000) |
stocks29
reviewed
Mar 29, 2025
| end | ||
| |> Task.async() | ||
| |> Task.await() | ||
| |> Task.await(connect_timeout + recv_timeout) |
There was a problem hiding this comment.
I do wonder if the timeout here should just be :infinity and let Req timeout and respond instead.
Also worth considering... why even run this in a task if we're immediately await()ing it?
There was a problem hiding this comment.
I put up another PR which removes the Task completely since it doesn't appear to serve any purpose:
mwhitworth
force-pushed
the
req-respect-timeouts
branch
from
a5a2980 to
e50b012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #236
respecting these timeout values means we can keep the task timeout and the actual request timeouts in line