Skip to content

Req adapter: respect connect_timeout + recv_timeout client options for timeout #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Req adapter: respect connect_timeout + recv_timeout client options for timeout #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/reverse_proxy_plug/http_client/adapters/req.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,20 @@ if Code.ensure_loaded?(Req) do
end

defp async_request(req, parent) do
connect_timeout =
req.options
|> Keyword.get(:connect_options, [])
|> Keyword.get(:timeout, 30_000)

recv_timeout = Keyword.get(req.options, :recv_timeout, 15_000)
Copy link
Contributor

@stocks29 stocks29 Mar 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the option for req is :receive_timeout not :recv_timeout

https://hexdocs.pm/req/Req.html#new/1

Suggested change
recv_timeout = Keyword.get(req.options, :recv_timeout, 15_000)
recv_timeout = Keyword.get(req.options, :receive_timeout, 15_000)


fn ->
ret = request(req)
send(parent, :eof)
ret
end
|> Task.async()
|> Task.await()
|> Task.await(connect_timeout + recv_timeout)
Copy link
Contributor

@stocks29 stocks29 Mar 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if the timeout here should just be :infinity and let Req timeout and respond instead.

Also worth considering... why even run this in a task if we're immediately await()ing it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put up another PR which removes the Task completely since it doesn't appear to serve any purpose:

#239

end

defp body_stream do
Expand Down