Fixes #38498 - Add Reboot power operation to Redfish provider #917
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanou
force-pushed
the
fix3073_bmc_reboot_reset_patch2
branch
2 times, most recently
from
186f889 to
817ae1a
Compare
vanou
changed the title
vanou
force-pushed
the
fix3073_bmc_reboot_reset_patch2
branch
from
817ae1a to
cde907f
Compare
vanou
force-pushed
the
fix3073_bmc_reboot_reset_patch2
branch
from
cde907f to
be04a0e
Compare
vanou
force-pushed
the
fix3073_bmc_reboot_reset_patch2
branch
2 times, most recently
from
d20515f to
1517ca5
Compare
vanou
force-pushed
the
fix3073_bmc_reboot_reset_patch2
branch
from
1517ca5 to
97217b2
Compare
|
@spesnova717, To resolve the merge conflicts, can you please rebase the branch over the latest |
vanou
force-pushed
the
fix3073_bmc_reboot_reset_patch2
branch
from
97217b2 to
8633964
Compare
|
@stejskalleos |
vanou
force-pushed
the
fix3073_bmc_reboot_reset_patch2
branch
from
8633964 to
a2bf9a5
Compare
stejskalleos
previously approved these changes
Sep 23, 2025
Bug #3073 is caused by 3 things:
1. Foreman core doesn't call BMC proxy's API correctly
- Changing power state to 'Reboot' via Web GUI calls BMC proxy's 'soft'
power action
- Changing power state to 'Reset' via Web GUI calls BMC proxy's 'cycle'
power action
2. Foreman BMC proxy doesn't support reboot at all BMC provider
3. Foreman BMC proxy doesn't support reset(powerreset) at Redfish provider
2nd & 3rd item are mentioned in #38498. And this PR fixes 2nd item.
For backward compatibility, power_action_v2 capability is introduced
to smart proxy at PRs related to #38498. PR related to #3073 adds logic
to determine if smart proxy supports this capability into Foreman core.
vanou
force-pushed
the
fix3073_bmc_reboot_reset_patch2
branch
from
a2bf9a5 to
af23262
Compare
|
@stejskalleos |
stejskalleos
approved these changes
Sep 24, 2025
|
Thanks @vanou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug #3073 is caused by 3 things:
2nd & 3rd item are mentioned in #38498. And this PR fixes 2nd item.
Modifications in this PR
This PR does 2 things to make BMC smart proxy support reboot power action:
rebootpower action and call BMC provider'spowerrebootmethodpowerrebootmethod to Redfish provider class which makes Redfish server doGracefulRestartreset action(According to IPMI v2.0 specification, IPMI doesn't support Reboot)