Skip to content

Conversation

ic0ns
Copy link
Contributor

@ic0ns ic0ns commented Jun 30, 2025

Summary

  • Updates javadoc comments to reference DataConverter instead of the deprecated ArrayConverter class
  • Fixes outdated documentation in byte array modification classes

Details

While investigating the deprecation warnings mentioned in the task, I found that all actual code references to ArrayConverter have already been migrated to use DataConverter. However, the javadoc comments in several files still referenced the old ArrayConverter class.

This PR updates the following javadoc comments:

  • ByteArrayAppendValueModification: Updated comment about concatenate method
  • ByteArrayDuplicateModification: Updated comment about concatenate method
  • ByteArrayInsertValueModification: Updated comment about concatenation operations
  • ByteArrayPrependValueModification: Updated comment about concatenate method

Test plan

  • Code compiles successfully with mvn clean compile
  • All tests pass with mvn test
  • Spotless formatting applied with mvn spotless:apply
  • No functional changes - only documentation updates

…precated ArrayConverter

- Updated javadoc comments in ByteArrayAppendValueModification
- Updated javadoc comments in ByteArrayDuplicateModification
- Updated javadoc comments in ByteArrayInsertValueModification
- Updated javadoc comments in ByteArrayPrependValueModification

All actual code references to ArrayConverter have already been migrated to DataConverter.
This commit only updates the documentation to reflect the current implementation.
@ic0ns ic0ns merged commit 41baf1b into main Jun 30, 2025
12 checks passed
@ic0ns ic0ns deleted the fix/array-converter-deprecation branch June 30, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant