fix: imports in bundlers #1395
Open
fix: imports in bundlers #1395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
browserbundle is misleading. It points to thees-toolkit/compatand does not contain any exports. This means if youimport { flatten } from "es-toolkit"in a bundler which prioritises thebrowserfieldflattenwill beundefined. Alternatively if you intended toimport "es-toolkit"and use a method not exposed by thees-toolkit/compatlayer such asflattenObjectthe function will beundefined. Since its common for bundlers to wrap the modules the_global may also not be exposed.The simplest fix is to remove the
browserbundle and let bundlers take over, however, if there is a desire to expose a script which provides thees-toolkit/compatlayer as a global I suggest we explore moving it to a new subpath export.