Skip to content

fix: imports in bundlers #1395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: imports in bundlers #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.1",
"@eslint/js": "^9.9.0",
"@rollup/plugin-terser": "^0.4.4",
"@rollup/plugin-typescript": "^12.1.0",
"@trivago/prettier-plugin-sort-imports": "^4.3.0",
"@types/broken-link-checker": "^0",
Expand Down Expand Up @@ -99,7 +98,6 @@
"publishConfig": {
"access": "public",
"main": "./dist/index.js",
"browser": "./dist/browser.global.js",
"module": "./dist/index.mjs",
"exports": {
".": {
Expand Down
48 changes: 0 additions & 48 deletions rollup.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { createRequire } from 'node:module';
import { dirname, join } from 'node:path';
import { fileURLToPath } from 'node:url';
import dtsPlugin from 'rollup-plugin-dts';
import terserPlugin from '@rollup/plugin-terser';
import tsPlugin from '@rollup/plugin-typescript';

// eslint-disable-next-line @typescript-eslint/naming-convention
Expand Down Expand Up @@ -44,12 +43,6 @@ export default () => {
entrypoints,
outDir: 'dist',
}),
browserBuildConfig({
inputFile: './src/compat/index.ts',
outFile: packageJson.publishConfig.browser,
name: '_',
sourcemap: false,
}),
];
};

Expand Down Expand Up @@ -93,47 +86,6 @@ function libBuildOptions({ entrypoints, extension, format, outDir, sourcemap })
};
}

/**
* @type {(options: {inputFile: string; outFile: string; name: string, sourcemap: boolean}) => import('rollup').RollupOptions}
*/
function browserBuildConfig({ inputFile, outFile, name, sourcemap }) {
return {
input: inputFile,
plugins: [
tsPlugin({
exclude: [...testPatterns],
compilerOptions: {
sourceMap: sourcemap,
inlineSources: sourcemap || undefined,
removeComments: true,
declaration: false,
},
}),
],
output: {
plugins: [
// Minify with terser, but with a configuration that optimizes for
// readability in browser DevTools (after re-indenting by DevTools).
terserPlugin({
// Terser defaults to ES5 for syntax it adds or rewrites
ecma: 2020,
// Readable function names (not just in final export)
keep_fnames: true,
// Turn off compress.sequences to keep the assignments to the toolkit
// object readable, instead of turning them into a huge list of
// comma-separated expressions.
compress: { sequences: false },
}),
],
format: 'iife',
name,
file: outFile,
sourcemap,
generatedCode: 'es2015',
},
};
}

/**
* @type {(options: {entrypoints: string[]; outDir: string}) => import('rollup').RollupOptions}
*/
Expand Down
79 changes: 3 additions & 76 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2134,16 +2134,6 @@ __metadata:
languageName: node
linkType: hard

"@jridgewell/source-map@npm:^0.3.3":
version: 0.3.6
resolution: "@jridgewell/source-map@npm:0.3.6"
dependencies:
"@jridgewell/gen-mapping": "npm:^0.3.5"
"@jridgewell/trace-mapping": "npm:^0.3.25"
checksum: 10c0/6a4ecc713ed246ff8e5bdcc1ef7c49aaa93f7463d948ba5054dda18b02dcc6a055e2828c577bcceee058f302ce1fc95595713d44f5c45e43d459f88d267f2f04
languageName: node
linkType: hard

"@jridgewell/sourcemap-codec@npm:^1.4.10, @jridgewell/sourcemap-codec@npm:^1.4.14, @jridgewell/sourcemap-codec@npm:^1.5.0":
version: 1.5.0
resolution: "@jridgewell/sourcemap-codec@npm:1.5.0"
Expand Down Expand Up @@ -2379,22 +2369,6 @@ __metadata:
languageName: node
linkType: hard

"@rollup/plugin-terser@npm:^0.4.4":
version: 0.4.4
resolution: "@rollup/plugin-terser@npm:0.4.4"
dependencies:
serialize-javascript: "npm:^6.0.1"
smob: "npm:^1.0.0"
terser: "npm:^5.17.4"
peerDependencies:
rollup: ^2.0.0||^3.0.0||^4.0.0
peerDependenciesMeta:
rollup:
optional: true
checksum: 10c0/b9cb6c8f02ac1c1344019e9fb854321b74f880efebc41b6bdd84f18331fce0f4a2aadcdb481042245cd3f409b429ac363af71f9efec4a2024731d67d32af36ee
languageName: node
linkType: hard

"@rollup/plugin-typescript@npm:^12.1.0":
version: 12.1.0
resolution: "@rollup/plugin-typescript@npm:12.1.0"
Expand Down Expand Up @@ -3637,7 +3611,7 @@ __metadata:
languageName: node
linkType: hard

"acorn@npm:^8.11.0, acorn@npm:^8.14.0, acorn@npm:^8.4.1, acorn@npm:^8.6.0, acorn@npm:^8.8.2, acorn@npm:^8.9.0":
"acorn@npm:^8.11.0, acorn@npm:^8.14.0, acorn@npm:^8.4.1, acorn@npm:^8.6.0, acorn@npm:^8.9.0":
version: 8.14.1
resolution: "acorn@npm:8.14.1"
bin:
Expand Down Expand Up @@ -4663,13 +4637,6 @@ __metadata:
languageName: node
linkType: hard

"commander@npm:^2.20.0":
version: 2.20.3
resolution: "commander@npm:2.20.3"
checksum: 10c0/74c781a5248c2402a0a3e966a0a2bba3c054aad144f5c023364be83265e796b20565aa9feff624132ff629aa64e16999fa40a743c10c12f7c61e96a794b99288
languageName: node
linkType: hard

"commondir@npm:^1.0.1":
version: 1.0.1
resolution: "commondir@npm:1.0.1"
Expand Down Expand Up @@ -5368,7 +5335,6 @@ __metadata:
"@changesets/changelog-github": "npm:^0.5.0"
"@changesets/cli": "npm:^2.27.1"
"@eslint/js": "npm:^9.9.0"
"@rollup/plugin-terser": "npm:^0.4.4"
"@rollup/plugin-typescript": "npm:^12.1.0"
"@trivago/prettier-plugin-sort-imports": "npm:^4.3.0"
"@types/broken-link-checker": "npm:^0"
Expand Down Expand Up @@ -9249,15 +9215,6 @@ __metadata:
languageName: node
linkType: hard

"randombytes@npm:^2.1.0":
version: 2.1.0
resolution: "randombytes@npm:2.1.0"
dependencies:
safe-buffer: "npm:^5.1.0"
checksum: 10c0/50395efda7a8c94f5dffab564f9ff89736064d32addf0cc7e8bf5e4166f09f8ded7a0849ca6c2d2a59478f7d90f78f20d8048bca3cdf8be09d8e8a10790388f3
languageName: node
linkType: hard

"raw-body@npm:2.4.1":
version: 2.4.1
resolution: "raw-body@npm:2.4.1"
Expand Down Expand Up @@ -9670,7 +9627,7 @@ __metadata:
languageName: node
linkType: hard

"safe-buffer@npm:^5.0.1, safe-buffer@npm:^5.1.0, safe-buffer@npm:^5.1.2":
"safe-buffer@npm:^5.0.1, safe-buffer@npm:^5.1.2":
version: 5.2.1
resolution: "safe-buffer@npm:5.2.1"
checksum: 10c0/6501914237c0a86e9675d4e51d89ca3c21ffd6a31642efeba25ad65720bce6921c9e7e974e5be91a786b25aa058b5303285d3c15dbabf983a919f5f630d349f3
Expand Down Expand Up @@ -9784,15 +9741,6 @@ __metadata:
languageName: node
linkType: hard

"serialize-javascript@npm:^6.0.1":
version: 6.0.2
resolution: "serialize-javascript@npm:6.0.2"
dependencies:
randombytes: "npm:^2.1.0"
checksum: 10c0/2dd09ef4b65a1289ba24a788b1423a035581bef60817bea1f01eda8e3bda623f86357665fe7ac1b50f6d4f583f97db9615b3f07b2a2e8cbcb75033965f771dd2
languageName: node
linkType: hard

"set-blocking@npm:^2.0.0":
version: 2.0.0
resolution: "set-blocking@npm:2.0.0"
Expand Down Expand Up @@ -9963,13 +9911,6 @@ __metadata:
languageName: node
linkType: hard

"smob@npm:^1.0.0":
version: 1.5.0
resolution: "smob@npm:1.5.0"
checksum: 10c0/a1067f23265812de8357ed27312101af49b89129eb973e3f26ab5856ea774f88cace13342e66e32470f933ccfa916e0e9d0f7ca8bbd4f92dfab2af45c15956c2
languageName: node
linkType: hard

"socks-proxy-agent@npm:^8.0.3":
version: 8.0.3
resolution: "socks-proxy-agent@npm:8.0.3"
Expand Down Expand Up @@ -9998,7 +9939,7 @@ __metadata:
languageName: node
linkType: hard

"source-map-support@npm:^0.5.16, source-map-support@npm:~0.5.20":
"source-map-support@npm:^0.5.16":
version: 0.5.21
resolution: "source-map-support@npm:0.5.21"
dependencies:
Expand Down Expand Up @@ -10497,20 +10438,6 @@ __metadata:
languageName: node
linkType: hard

"terser@npm:^5.17.4":
version: 5.31.3
resolution: "terser@npm:5.31.3"
dependencies:
"@jridgewell/source-map": "npm:^0.3.3"
acorn: "npm:^8.8.2"
commander: "npm:^2.20.0"
source-map-support: "npm:~0.5.20"
bin:
terser: bin/terser
checksum: 10c0/eb2b525dada9febd3db74e94bd295f9cd7abd809e4f9c6bbc795a3048ad50fd327c15eab99db383fa820239680eef6d2dbd7dc05361769c204ddee5cf684d41e
languageName: node
linkType: hard

"test-exclude@npm:^7.0.1":
version: 7.0.1
resolution: "test-exclude@npm:7.0.1"
Expand Down