Remove derived state check

[benjeffery]

As mentioned at jeromekelleher/sc2ts#554

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.58%. Comparing base (4bf2521) to head (98c038d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
+ Coverage   93.27%   95.58%   +2.30%     
==========================================
  Files          18       13       -5     
  Lines        6545     4753    -1792     
  Branches     1117      800     -317     
==========================================
- Hits         6105     4543    -1562     
+ Misses        299      159     -140     
+ Partials      141       51      -90     

Flag	Coverage Δ
C	?
python	95.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jeromekelleher]

Can we just remove check for > num alleles instead?

[jeromekelleher]

Is this what we did in the old branch, or did we just check for derived state being > 0? I can see checking for < 0 having value. I can't find the branch now either - is it on my fork

[benjeffery]

In your branch (https://github.com/jeromekelleher/tsinfer/blob/experimental-hmm/lib/tree_sequence_builder.c#L420) you have:

    if (derived_state < 0) {
        ret = TSI_ERR_BAD_MUTATION_DERIVED_STATE;
        goto out;
    }

[jeromekelleher]

Let's go with that then

[benjeffery]

Great - changed over to just remove the allele count check.