Allow open split view using the keyboard #19927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsrasmussen
requested changes
Aug 20, 2025
There was a problem hiding this comment.
Hi @engijlr
The changes look good and the functionality works as I would expect. I have added two small requests for changes.
...e/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts
Outdated
Show resolved
Hide resolved
...e/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts
Outdated
Show resolved
Hide resolved
...e/workspace/components/workspace-split-view/workspace-split-view-variant-selector.element.ts
Outdated
Show resolved
Hide resolved
madsrasmussen
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make the split-view button visible not only on hover, but also when the variant receives keyboard focus.
Changes:
-Added .variant:focus > .split-view, .variant:focus-within > .split-view
-Added a more descriptive label to the trigger button: label="Open variant options for split view"
How to test
-Set focus on the variant option using the keyboard, will be able to show and interact with the "open in split view" button