Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
85 commits
Select commit Hold shift + click to select a range
5f4b3ca
rename and deprecate the old name
madsrasmussen Oct 23, 2024
c3edc5b
add content detail context class scaffold
madsrasmussen Oct 23, 2024
fa8c1b9
wip move common logic to content workspace context base
madsrasmussen Oct 23, 2024
1fb22a0
add methods to get parent data
madsrasmussen Oct 23, 2024
6b00ea8
move more logic to content detail workspace base
madsrasmussen Oct 23, 2024
bd20747
temp move back
madsrasmussen Oct 23, 2024
846479e
add check for data
madsrasmussen Oct 23, 2024
2d2b32c
wip implement UmbContentDetailWorkspaceBase for media workspace context
madsrasmussen Oct 23, 2024
487908a
provide entity context
madsrasmussen Oct 23, 2024
c4b42b9
remove duplicated code
madsrasmussen Oct 23, 2024
20638d5
move more logic to base class
madsrasmussen Oct 23, 2024
b808d95
remove unused
madsrasmussen Oct 23, 2024
c5e1fa4
wip implement base class on member workspace
madsrasmussen Oct 23, 2024
3d91fcc
make UmbContentDetailModel generic and pass variant model type
madsrasmussen Oct 23, 2024
5fe335c
use create scaffold method
madsrasmussen Oct 23, 2024
c0ecd94
type casting
madsrasmussen Oct 23, 2024
b25b348
call create scaffold in member workspace context
madsrasmussen Oct 23, 2024
f0b612e
add back observables for create and update date
madsrasmussen Oct 23, 2024
f204d4d
use correct unique type
madsrasmussen Oct 23, 2024
466623c
pass content type model
madsrasmussen Oct 23, 2024
ed6535e
pass variant option model
madsrasmussen Oct 23, 2024
d2d4a0c
pass types
madsrasmussen Oct 23, 2024
6a14350
align local type names
madsrasmussen Oct 23, 2024
967b714
use correct local type
madsrasmussen Oct 23, 2024
2918e00
add variant picker interface
madsrasmussen Oct 23, 2024
44c569c
pass in modal token
madsrasmussen Oct 23, 2024
6f39dbb
pass save modal
madsrasmussen Oct 23, 2024
4fad108
update types
madsrasmussen Oct 23, 2024
563b42a
add setVariantScaffold method
madsrasmussen Oct 24, 2024
ffd1f73
set variant scaffold
madsrasmussen Oct 24, 2024
0e8b458
add js docs
madsrasmussen Oct 24, 2024
8750121
pass types
madsrasmussen Oct 24, 2024
31e739d
deprecate getContentTypeId and implement getContentTypeUnique
madsrasmussen Oct 24, 2024
b006292
add js docs
madsrasmussen Oct 24, 2024
b4ebee2
add docs
madsrasmussen Oct 24, 2024
49acdb8
add more docs
madsrasmussen Oct 24, 2024
ca60dc8
add public to public methods
madsrasmussen Oct 24, 2024
5b2ecae
Merge branch 'main' into v15/feature/content-workspace-base
madsrasmussen Oct 24, 2024
581dc09
add abstract method createPropertyDatasetContext
madsrasmussen Oct 24, 2024
cec3297
add readonly back
madsrasmussen Oct 24, 2024
442d16f
add js docs
madsrasmussen Oct 24, 2024
7fedd71
add js docs
madsrasmussen Oct 24, 2024
5135b73
Update types.ts
madsrasmussen Oct 24, 2024
05624dc
Merge branch 'main' into v15/feature/content-workspace-base
madsrasmussen Oct 24, 2024
f00f0f7
implement on document blueprint
madsrasmussen Oct 24, 2024
76b7e29
align resetState
madsrasmussen Oct 24, 2024
71cca74
add check for repository
madsrasmussen Oct 24, 2024
d926a24
align order
madsrasmussen Oct 24, 2024
330151e
remove
madsrasmussen Oct 24, 2024
fe2c266
export element
madsrasmussen Oct 24, 2024
2d2033a
allow to slot in custom variant selectors
madsrasmussen Oct 24, 2024
92fd8f2
make current variant selector more generic
madsrasmussen Oct 24, 2024
f669bcf
add specific variant selector for documents
madsrasmussen Oct 24, 2024
68649d5
render new variant selector for in document workspace
madsrasmussen Oct 24, 2024
4df2164
add null check
madsrasmussen Oct 24, 2024
879bd12
add label
madsrasmussen Oct 24, 2024
3fa1bd3
include context in the class name
madsrasmussen Oct 25, 2024
2db8b47
sort variants
madsrasmussen Oct 25, 2024
11c6a33
Merge branch 'main' into v15/feature/content-workspace-base
madsrasmussen Oct 28, 2024
f316c6d
Merge branch 'main' into v15/feature/content-workspace-base
madsrasmussen Oct 29, 2024
4202a19
Merge branch 'main' into v15/feature/content-workspace-base
nielslyngsoe Nov 4, 2024
ed98fab
Merge branch 'main' into v15/feature/content-workspace-base
nielslyngsoe Nov 5, 2024
15d068a
use slotchange callback + clean up
nielslyngsoe Nov 5, 2024
c6c512e
author on comment
nielslyngsoe Nov 5, 2024
8f50c20
jsdocs updates
nielslyngsoe Nov 5, 2024
f3ac97b
correct comment
nielslyngsoe Nov 5, 2024
7364118
jsdocs
nielslyngsoe Nov 5, 2024
3df3187
correct variant selector look
nielslyngsoe Nov 5, 2024
d306922
Merge branch 'main' into v15/feature/content-workspace-base
madsrasmussen Nov 6, 2024
1e1e12d
Merge branch 'main' into v15/feature/content-workspace-base
madsrasmussen Nov 6, 2024
861b34c
Merge branch 'main' into v15/feature/content-workspace-base
madsrasmussen Nov 6, 2024
2ed2204
Merge branch 'main' into v15/feature/content-workspace-base
nielslyngsoe Nov 7, 2024
f030908
Merge branch 'main' into v15/feature/content-workspace-base
madsrasmussen Nov 7, 2024
c335367
remove circular dependency + deprecate export
madsrasmussen Nov 7, 2024
ffc22e0
use relative imports inside a module
madsrasmussen Nov 7, 2024
755db18
use relative imports inside module
madsrasmussen Nov 7, 2024
7eb7552
fix circular import
madsrasmussen Nov 7, 2024
59e3e91
use relative imports
madsrasmussen Nov 7, 2024
0892de6
use relative imports
madsrasmussen Nov 7, 2024
60ee649
temp duplicate styling as we shouldn't depend on another elements sty…
madsrasmussen Nov 7, 2024
498ec8b
fix import
madsrasmussen Nov 7, 2024
4d378ae
lint fixes
nielslyngsoe Nov 7, 2024
5de8804
sort props to align with data source
nielslyngsoe Nov 7, 2024
1c0d7a8
update member manifests
nielslyngsoe Nov 7, 2024
89e6c19
move dictionary create action to top
nielslyngsoe Nov 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { manifests as workspaceViewManifests } from './views/manifests.js';
import { UMB_BLOCK_GRID_AREA_TYPE_WORKSPACE_ALIAS } from './index.js';
import { UmbSubmitWorkspaceAction } from '@umbraco-cms/backoffice/workspace';
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';
import { UmbSubmitWorkspaceAction, UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';

export const manifests: Array<UmbExtensionManifest> = [
...workspaceViewManifests,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';
import { UMB_BLOCK_GRID_AREA_TYPE_WORKSPACE_ALIAS } from '../index.js';
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';
import type { ManifestWorkspaceView } from '@umbraco-cms/backoffice/workspace';

export const workspaceViews: Array<ManifestWorkspaceView> = [
Expand Down
2 changes: 1 addition & 1 deletion src/packages/block/block-grid/workspace/views/manifests.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';
import { UMB_BLOCK_GRID_TYPE_WORKSPACE_ALIAS } from '../index.js';
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand Down
2 changes: 1 addition & 1 deletion src/packages/block/block-list/workspace/views/manifests.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';
import { UMB_BLOCK_LIST_TYPE_WORKSPACE_ALIAS } from '../index.js';
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand Down
2 changes: 1 addition & 1 deletion src/packages/block/block-rte/workspace/views/manifests.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';
import { UMB_BLOCK_RTE_TYPE_WORKSPACE_ALIAS } from '../index.js';
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand Down
3 changes: 1 addition & 2 deletions src/packages/block/block-type/workspace/manifests.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';
import { UMB_BLOCK_GRID_TYPE_WORKSPACE_ALIAS } from '../../block-grid/workspace/index.js';
import { UMB_BLOCK_LIST_TYPE_WORKSPACE_ALIAS } from '../../block-list/workspace/index.js';
import { UMB_BLOCK_RTE_TYPE_WORKSPACE_ALIAS } from '../../block-rte/workspace/index.js';
import { UmbSubmitWorkspaceAction } from '@umbraco-cms/backoffice/workspace';
import { UMB_WORKSPACE_CONDITION_ALIAS, UmbSubmitWorkspaceAction } from '@umbraco-cms/backoffice/workspace';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand Down
3 changes: 1 addition & 2 deletions src/packages/block/block/workspace/manifests.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { UMB_WORKSPACE_CONDITION_ALIAS } from '@umbraco-cms/backoffice/workspace';
import { UMB_BLOCK_WORKSPACE_ALIAS } from './index.js';
import { UmbSubmitWorkspaceAction } from '@umbraco-cms/backoffice/workspace';
import { UMB_WORKSPACE_CONDITION_ALIAS, UmbSubmitWorkspaceAction } from '@umbraco-cms/backoffice/workspace';

export const manifests: Array<UmbExtensionManifest> = [
{
Expand Down
7 changes: 6 additions & 1 deletion src/packages/core/content-type/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
export * from './components/index.js';
export * from './composition/index.js';
export * from './modals/index.js';
export * from './repository/index.js';
export * from './structure/index.js';
export * from './workspace/index.js';
export type * from './types.js';

/**
* @deprecated Use `UmbPropertyTypeBasedPropertyElement` from `@umbraco-cms/backoffice/content` instead.
* Export will be removed in version 17.
*/
export { UmbPropertyTypeBasedPropertyElement } from '../content/components/property-type-based-property/property-type-based-property.element.js';
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import type { UmbContentTypeModel, UmbPropertyTypeContainerModel } from '../../../types.js';
import type { UmbContentTypeContainerStructureHelper } from '../../../structure/index.js';
import { css, customElement, html, nothing, property, repeat, state, when } from '@umbraco-cms/backoffice/external/lit';
import { umbConfirmModal } from '@umbraco-cms/backoffice/modal';
import { UmbLitElement, umbFocus } from '@umbraco-cms/backoffice/lit-element';
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
import type {
UmbContentTypeContainerStructureHelper,
UmbContentTypeModel,
UmbPropertyTypeContainerModel,
} from '@umbraco-cms/backoffice/content-type';
import type { UUIInputEvent } from '@umbraco-cms/backoffice/external/uui';

import './content-type-design-editor-properties.element.js';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { UMB_CONTENT_TYPE_WORKSPACE_CONTEXT } from '../../content-type-workspace.context-token.js';
import type { UmbContentTypeModel, UmbPropertyTypeModel } from '../../../types.js';
import { UmbContentTypePropertyStructureHelper } from '../../../structure/index.js';
import { UMB_CONTENT_TYPE_DESIGN_EDITOR_CONTEXT } from './content-type-design-editor.context.js';
import type { UmbContentTypeDesignEditorPropertyElement } from './content-type-design-editor-property.element.js';
import {
Expand All @@ -13,17 +15,15 @@ import {
} from '@umbraco-cms/backoffice/external/lit';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
import { UmbContentTypePropertyStructureHelper } from '@umbraco-cms/backoffice/content-type';
import type { UmbContentTypeModel, UmbPropertyTypeModel } from '@umbraco-cms/backoffice/content-type';
import { type UmbSorterConfig, UmbSorterController } from '@umbraco-cms/backoffice/sorter';
import { UmbModalRouteRegistrationController } from '@umbraco-cms/backoffice/router';

import './content-type-design-editor-property.element.js';
import {
UMB_CREATE_PROPERTY_TYPE_WORKSPACE_PATH_PATTERN,
UMB_PROPERTY_TYPE_WORKSPACE_MODAL,
} from '@umbraco-cms/backoffice/property-type';

import './content-type-design-editor-property.element.js';

const SORTER_CONFIG: UmbSorterConfig<UmbPropertyTypeModel, UmbContentTypeDesignEditorPropertyElement> = {
getUniqueOfElement: (element) => {
return element.getAttribute('data-umb-property-id');
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type { UmbContentTypePropertyStructureHelper } from '../../../structure/index.js';
import type { UmbContentTypeModel, UmbPropertyTypeModel, UmbPropertyTypeScaffoldModel } from '../../../types.js';
import { UmbPropertyTypeContext } from './content-type-design-editor-property.context.js';
import { css, html, customElement, property, state, nothing } from '@umbraco-cms/backoffice/external/lit';
import { generateAlias } from '@umbraco-cms/backoffice/utils';
Expand All @@ -6,12 +8,6 @@ import { UmbDataTypeDetailRepository } from '@umbraco-cms/backoffice/data-type';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
import { UMB_EDIT_PROPERTY_TYPE_WORKSPACE_PATH_PATTERN } from '@umbraco-cms/backoffice/property-type';
import type {
UmbContentTypeModel,
UmbContentTypePropertyStructureHelper,
UmbPropertyTypeModel,
UmbPropertyTypeScaffoldModel,
} from '@umbraco-cms/backoffice/content-type';
import type { UUIInputElement, UUIInputLockElement, UUIInputEvent } from '@umbraco-cms/backoffice/external/uui';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { UMB_CONTENT_TYPE_WORKSPACE_CONTEXT } from '../../content-type-workspace.context-token.js';
import type { UmbContentTypeModel, UmbPropertyTypeContainerModel } from '../../../types.js';
import { UmbContentTypeContainerStructureHelper } from '../../../structure/index.js';
import { UMB_CONTENT_TYPE_DESIGN_EDITOR_CONTEXT } from './content-type-design-editor.context.js';
import type { UmbContentTypeWorkspaceViewEditGroupElement } from './content-type-design-editor-group.element.js';
import { css, customElement, html, nothing, property, repeat, state } from '@umbraco-cms/backoffice/external/lit';
import { UmbContentTypeContainerStructureHelper } from '@umbraco-cms/backoffice/content-type';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { UmbModalRouteRegistrationController } from '@umbraco-cms/backoffice/router';
import { UmbSorterController } from '@umbraco-cms/backoffice/sorter';
import { UMB_WORKSPACE_MODAL } from '@umbraco-cms/backoffice/workspace';
import type { UmbContentTypeModel, UmbPropertyTypeContainerModel } from '@umbraco-cms/backoffice/content-type';
import type { UmbSorterConfig } from '@umbraco-cms/backoffice/sorter';

import './content-type-design-editor-properties.element.js';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,14 @@
import { UMB_CONTENT_TYPE_WORKSPACE_CONTEXT } from '../../content-type-workspace.context-token.js';
import type { UmbContentTypeModel, UmbPropertyTypeContainerModel } from '../../../types.js';
import {
UmbContentTypeContainerStructureHelper,
UmbContentTypeMoveRootGroupsIntoFirstTabHelper,
} from '../../../structure/index.js';
import { UMB_COMPOSITION_PICKER_MODAL } from '../../../modals/index.js';
import type { UmbContentTypeDesignEditorTabElement } from './content-type-design-editor-tab.element.js';
import { UmbContentTypeDesignEditorContext } from './content-type-design-editor.context.js';
import { css, html, customElement, state, repeat, ifDefined, nothing } from '@umbraco-cms/backoffice/external/lit';
import type { UUIInputElement, UUIInputEvent, UUITabElement } from '@umbraco-cms/backoffice/external/uui';
import {
UMB_COMPOSITION_PICKER_MODAL,
UmbContentTypeContainerStructureHelper,
UmbContentTypeMoveRootGroupsIntoFirstTabHelper,
type UmbContentTypeModel,
type UmbPropertyTypeContainerModel,
} from '@umbraco-cms/backoffice/content-type';
import { encodeFolderName } from '@umbraco-cms/backoffice/router';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { CompositionTypeModel } from '@umbraco-cms/backoffice/external/backend-api';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import type { UmbPropertyEditorConfig } from '../../../property-editor/index.js';
import type { UmbPropertyTypeModel } from '../../types.js';
import { UmbContentPropertyContext } from '../../content-property.context.js';
import type { UmbPropertyEditorConfig } from '@umbraco-cms/backoffice/property-editor';
import { css, customElement, html, ifDefined, property, state } from '@umbraco-cms/backoffice/external/lit';
import { UmbContentPropertyContext } from '@umbraco-cms/backoffice/content';
import { UmbDataTypeDetailRepository } from '@umbraco-cms/backoffice/data-type';
import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
import { UmbLitElement } from '@umbraco-cms/backoffice/lit-element';
import { UmbTextStyles } from '@umbraco-cms/backoffice/style';
import type { UmbDataTypeDetailModel } from '@umbraco-cms/backoffice/data-type';
import type { UmbObserverController } from '@umbraco-cms/backoffice/observable-api';
import { UMB_UNSUPPORTED_EDITOR_SCHEMA_ALIASES } from '@umbraco-cms/backoffice/property';
import type { UmbPropertyTypeModel } from '@umbraco-cms/backoffice/content-type';

@customElement('umb-property-type-based-property')
export class UmbPropertyTypeBasedPropertyElement extends UmbLitElement {
Expand Down
2 changes: 1 addition & 1 deletion src/packages/core/content/constants.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const UMB_CONTENT_SECTION_ALIAS = 'Umb.Section.Content';
export const UMB_CONTENT_SECTION_ALIAS = 'Umb.Section.Content';
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { UmbContentLikeDetailModel, UmbPotentialContentValueModel } from '../types.js';
import { UmbControllerBase } from '@umbraco-cms/backoffice/class-api';
import type { UmbContentLikeDetailModel, UmbPotentialContentValueModel } from '@umbraco-cms/backoffice/content';
import { createExtensionApi } from '@umbraco-cms/backoffice/extension-api';
import { umbExtensionsRegistry } from '@umbraco-cms/backoffice/extension-registry';
import { UmbVariantId, type UmbVariantDataModel } from '@umbraco-cms/backoffice/variant';
Expand Down
3 changes: 3 additions & 0 deletions src/packages/core/content/index.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
export { UMB_CONTENT_PROPERTY_CONTEXT } from './content-property.context-token.js';
export { UmbContentPropertyContext } from './content-property.context.js';

export * from './collection/index.js';
export * from './components/index.js';
export * from './constants.js';
export * from './controller/merge-content-variant-data.controller.js';
export * from './manager/index.js';
export * from './property-dataset-context/index.js';
export * from './variant-picker/index.js';
export * from './workspace/index.js';
export type * from './types.js';
13 changes: 11 additions & 2 deletions src/packages/core/content/manager/content-data-manager.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import type { UmbContentDetailModel } from '../types.js';
import { UmbElementWorkspaceDataManager } from './element-data-manager.js';
import type { UmbContentDetailModel } from '@umbraco-cms/backoffice/content';
import type { UmbControllerHost } from '@umbraco-cms/backoffice/controller-api';
import { appendToFrozenArray, jsonStringComparison } from '@umbraco-cms/backoffice/observable-api';
import { UmbVariantId, type UmbEntityVariantModel } from '@umbraco-cms/backoffice/variant';
Expand All @@ -14,11 +14,20 @@ export class UmbContentWorkspaceDataManager<
//#repository;
#variantScaffold?: ModelVariantType;

constructor(host: UmbControllerHost, variantScaffold: ModelVariantType) {
constructor(host: UmbControllerHost, variantScaffold?: ModelVariantType) {
super(host);
this.#variantScaffold = variantScaffold;
}

/**
* Sets the variant scaffold data
* @param {ModelVariantType} variantScaffold The variant scaffold data
* @memberof UmbContentWorkspaceDataManager
*/
setVariantScaffold(variantScaffold: ModelVariantType) {
this.#variantScaffold = variantScaffold;
}

ensureVariantData(variantId: UmbVariantId) {
this.updateVariantData(variantId);
}
Expand Down
2 changes: 1 addition & 1 deletion src/packages/core/content/manager/element-data-manager.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { UmbMergeContentVariantDataController } from '../controller/merge-content-variant-data.controller.js';
import type { UmbElementDetailModel } from '@umbraco-cms/backoffice/content';
import type { UmbElementDetailModel } from '../types.js';
import { UmbVariantId } from '@umbraco-cms/backoffice/variant';
import { UmbEntityWorkspaceDataManager, type UmbWorkspaceDataManager } from '@umbraco-cms/backoffice/workspace';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ export abstract class UmbElementPropertyDatasetContext<
}

override destroy() {
super.destroy();
this.#propertyVariantIdMap.destroy();
this.#propertyVariantIdMap?.destroy();
(this.#propertyVariantIdMap as unknown) = undefined;
super.destroy();
}
}
5 changes: 3 additions & 2 deletions src/packages/core/content/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ export interface UmbPotentialContentValueModel<ValueType = unknown> extends UmbP
segment?: string | null;
}

export interface UmbContentDetailModel extends UmbElementDetailModel {
export interface UmbContentDetailModel<VariantModelType extends UmbEntityVariantModel = UmbEntityVariantModel>
extends UmbElementDetailModel {
unique: string;
entityType: string;
variants: Array<UmbEntityVariantModel>;
variants: Array<VariantModelType>;
}

export interface UmbContentLikeDetailModel
Expand Down
1 change: 1 addition & 0 deletions src/packages/core/content/variant-picker/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export * from './types.js';
8 changes: 8 additions & 0 deletions src/packages/core/content/variant-picker/types.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export interface UmbContentVariantPickerData<VariantOptionModelType> {
options: Array<VariantOptionModelType>;
pickableFilter?: (variantOption: VariantOptionModelType) => boolean;
}

export interface UmbContentVariantPickerValue {
selection: Array<string>;
}
Loading
Loading