feat(mcp): add-is-conference-in-progress-to-agent-contact-event #4558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhmenon
approved these changes
Nov 3, 2025
Contributor
adhmenon
left a comment
adhmenon
left a comment
There was a problem hiding this comment.
Changes LGTM.
Approving with 2 minor comments
| }); | ||
| switch (payload.data.type) { | ||
| case CC_EVENTS.AGENT_CONTACT: | ||
| case CC_EVENTS.AGENT_CONTACT: { |
Contributor
There was a problem hiding this comment.
Nit: Not sure if we need this bracket here.
| }); | ||
|
|
||
| // Pre-calculate isConferenceInProgress for the initial task data | ||
| const simulatedTaskForAgentContact = { |
Contributor
There was a problem hiding this comment.
Why do we need this constant? Can we not use payload.data directly?
Contributor
Author
There was a problem hiding this comment.
Because isConferenceInProgress is taking task object as an parameter, so we needed an updated task object. We can pass payload data, but we wanted to keep it consistent with all other utils(task object as parameter)
rsarika
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPLETES #< INSERT LINK TO ISSUE >
This pull request addresses
Fixed two issues:
When an agent performs a switch call during a consult or conference, and then adds another agent to the conference, the "add agent to conference" operation was failing because the ToAddress parameter was being sent as null.
When refreshing one window during multi-login via extension mode, if the agent is in conference mode, the conference-related call controls were not being retained.
by making the following changes
< DESCRIBE YOUR CHANGES >
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.