Skip to content

Conversation

@jatZama
Copy link
Member

@jatZama jatZama commented Oct 7, 2025

@isaacdecoded isaacdecoded marked this pull request as ready for review October 13, 2025 09:35
@jatZama
Copy link
Member Author

jatZama commented Oct 14, 2025

Good work, but I think you forgot to rerun selectors computation in your last commit, since you changed one of the custom errors signatures, right?
Aslo what was the rationale behind renaming NewDelegation event to DelegateAccount? I don't remember any discussion on this topic.

@isaacdecoded
Copy link
Contributor

Good work, but I think you forgot to rerun selectors computation in your last commit, since you changed one of the custom errors signatures, right?

I think the selectors are up-to-date already.

Aslo what was the rationale behind renaming NewDelegation event to DelegateAccount? I don't remember any discussion on this topic.

Basically, to follow the same convention we have been using for others events, I mean, using same/similar name as the contract method that triggers it. E.g., RevokedDelegation for revokeDelegation(), AllowedForDecryption for allowForDecryption() , etc.

Copy link
Contributor

@isaacdecoded isaacdecoded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jatZama jatZama merged commit 99f3b67 into main Oct 14, 2025
107 checks passed
@jatZama jatZama deleted the delegateUserDecrypt branch October 14, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants