Port/traversability #35
Merged
+704
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhhughes
approved these changes
Sep 15, 2025
Comment on lines
64
to
65
| float slice_height = 2.0f; // Height of the slice to visualize in meteres. | ||
| bool use_relative_height = false; |
There was a problem hiding this comment.
(minor) I'd rename slice height to be drawing_offset_z(and use_relative_offset instead of use_relative_height) and change the comment, I use slice_height in other voxel-grid visualizers to mean "height to take a 2D slice at"
Schmluk
force-pushed
the
port/traversability
branch
from
304e851 to
3cc2be5
Compare
nathanhhughes
pushed a commit
that referenced
this pull request
Sep 16, 2025
* port traversability visualization, builds * fix segfaults * run linting on all files * address review comments
nathanhhughes
pushed a commit
that referenced
this pull request
Sep 16, 2025
* port traversability visualization, builds * fix segfaults * run linting on all files * address review comments
nathanhhughes
pushed a commit
that referenced
this pull request
Sep 30, 2025
* port traversability visualization, builds * fix segfaults * run linting on all files * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Places2dandFrontiersto nor segfault.