Skip to content

Conversation

@justsmth
Copy link
Contributor

@justsmth justsmth commented Oct 17, 2025

Issues:

Addresses: aws/aws-lc-rs#932

Description of changes:

Adds library support for NetBSD.

Call-outs:

Testing:

Adds tests for both x86-64 and aarch64.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.41%. Comparing base (d826708) to head (429ab7d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2754      +/-   ##
==========================================
- Coverage   78.42%   78.41%   -0.02%     
==========================================
  Files         683      683              
  Lines      116283   116283              
  Branches    16404    16405       +1     
==========================================
- Hits        91194    91182      -12     
- Misses      24213    24225      +12     
  Partials      876      876              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the support-netbsd branch 5 times, most recently from 799efbe to 4b4da80 Compare November 5, 2025 15:41
@justsmth justsmth force-pushed the support-netbsd branch 14 times, most recently from 33d4c8a to a4b0dfe Compare November 6, 2025 23:11
@justsmth justsmth changed the title [DRAFT] Support NetBSD Support NetBSD Nov 7, 2025
@justsmth justsmth marked this pull request as ready for review November 7, 2025 13:00
@justsmth justsmth requested a review from a team as a code owner November 7, 2025 13:00
@justsmth justsmth requested review from torben-hansen and removed request for MartinHusemann November 7, 2025 13:10
Copy link

@MartinHusemann MartinHusemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@justsmth justsmth requested a review from nebeid November 7, 2025 14:22
@justsmth justsmth merged commit 4ed9b0b into aws:main Nov 7, 2025
383 of 390 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants