generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 151
Support NetBSD #2754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support NetBSD #2754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
- Coverage 78.42% 78.41% -0.02%
==========================================
Files 683 683
Lines 116283 116283
Branches 16404 16405 +1
==========================================
- Hits 91194 91182 -12
- Misses 24213 24225 +12
Partials 876 876 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1d7d956 to
8dc1761
Compare
799efbe to
4b4da80
Compare
33d4c8a to
a4b0dfe
Compare
a4b0dfe to
61aaea0
Compare
MartinHusemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
nebeid
approved these changes
Nov 7, 2025
torben-hansen
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses: aws/aws-lc-rs#932
Description of changes:
Adds library support for NetBSD.
Call-outs:
No route to host. I suspect that it's attempting to connect via IPv6 and not finding appropriate routing for it. I disabled this test for NetBSD.Testing:
Adds tests for both x86-64 and aarch64.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.