Fix crash and synchronize gui when disabling gi with active debug visualization mode
#3062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: momo <[email protected]>
iche033
approved these changes
Sep 4, 2025
|
@mergify backport gz-sim10 gz-sim9 gz-sim8 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
…ualization mode (#3062) When gi is being disabled (Enabled changes from true to false), the code sets the debug visualization mode to None, marks it as dirty, and sets a flag. After releasing the mutex lock, if the flag is set, it emits the DebugVisualizationModeChanged signal to notify the GUI to update. This ensures internal state consistency and prevents crashes by forcing the debug visualization mode to None when gi is off. Emitting the signal outside the lock avoids deadlocks and keeps the GUI synchronized with the internal state. Signed-off-by: momo <[email protected]> (cherry picked from commit 42ab45a)
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
…ualization mode (#3062) When gi is being disabled (Enabled changes from true to false), the code sets the debug visualization mode to None, marks it as dirty, and sets a flag. After releasing the mutex lock, if the flag is set, it emits the DebugVisualizationModeChanged signal to notify the GUI to update. This ensures internal state consistency and prevents crashes by forcing the debug visualization mode to None when gi is off. Emitting the signal outside the lock avoids deadlocks and keeps the GUI synchronized with the internal state. Signed-off-by: momo <[email protected]> (cherry picked from commit 42ab45a)
8 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
…ualization mode (#3062) When gi is being disabled (Enabled changes from true to false), the code sets the debug visualization mode to None, marks it as dirty, and sets a flag. After releasing the mutex lock, if the flag is set, it emits the DebugVisualizationModeChanged signal to notify the GUI to update. This ensures internal state consistency and prevents crashes by forcing the debug visualization mode to None when gi is off. Emitting the signal outside the lock avoids deadlocks and keeps the GUI synchronized with the internal state. Signed-off-by: momo <[email protected]> (cherry picked from commit 42ab45a)
8 tasks
iche033
pushed a commit
that referenced
this pull request
Sep 5, 2025
…ualization mode (#3062) When gi is being disabled (Enabled changes from true to false), the code sets the debug visualization mode to None, marks it as dirty, and sets a flag. After releasing the mutex lock, if the flag is set, it emits the DebugVisualizationModeChanged signal to notify the GUI to update. This ensures internal state consistency and prevents crashes by forcing the debug visualization mode to None when gi is off. Emitting the signal outside the lock avoids deadlocks and keeps the GUI synchronized with the internal state. Signed-off-by: momo <[email protected]> (cherry picked from commit 42ab45a)
iche033
pushed a commit
that referenced
this pull request
Sep 5, 2025
…ualization mode (#3062) When gi is being disabled (Enabled changes from true to false), the code sets the debug visualization mode to None, marks it as dirty, and sets a flag. After releasing the mutex lock, if the flag is set, it emits the DebugVisualizationModeChanged signal to notify the GUI to update. This ensures internal state consistency and prevents crashes by forcing the debug visualization mode to None when gi is off. Emitting the signal outside the lock avoids deadlocks and keeps the GUI synchronized with the internal state. Signed-off-by: momo <[email protected]> (cherry picked from commit 42ab45a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3060
Summary
When
giis being disabled (Enabledchanges fromtruetofalse), the code sets the debug visualization mode toNone, marks it as dirty, and sets a flag. After releasing the mutex lock, if theflagis set, it emits theDebugVisualizationModeChangedsignal to notify the GUI to update.This ensures internal state consistency and prevents crashes by forcing the debug visualization mode to
Nonewhengiis off. Emitting the signal outside the lock avoids deadlocks and keeps the GUI synchronized with the internal state.Checklist
codecheckpassed (See contributing)