Skip to content

Fix crash and synchronize gui when disabling gi with active debug visualization mode #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

Fix crash and synchronize gui when disabling gi with active debug visualization mode #3062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/gui/plugins/global_illumination_vct/GlobalIlluminationVct.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,23 @@ void GlobalIlluminationVct::UpdateOctantCount(int _axis, uint32_t _count)
//////////////////////////////////////////////////
void GlobalIlluminationVct::SetEnabled(const bool _enabled)
{
std::lock_guard<std::mutex> lock(this->dataPtr->serviceMutex);
this->dataPtr->enabled = _enabled;
this->dataPtr->visualDirty = true;
bool needEmitDebugVisChanged = false;
{
std::lock_guard<std::mutex> lock(this->dataPtr->serviceMutex);
if (this->dataPtr->enabled && !_enabled)
{
// When disabling GI, force debugVisMode to None for safety
this->dataPtr->debugVisMode = rendering::GlobalIlluminationVct::DVM_None;
this->dataPtr->debugVisualizationDirty = true;
needEmitDebugVisChanged = true;
}
this->dataPtr->enabled = _enabled;
this->dataPtr->visualDirty = true;
}
if (needEmitDebugVisChanged)
{
this->DebugVisualizationModeChanged();
}
}

//////////////////////////////////////////////////
Expand Down
Loading