-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add package.json exports #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these PRs draft, still?
I want to add one more pr to this stack with support for the solana addresses and afterwards I will put all the stack in Ready to Review |
WalkthroughThe pull request adds an Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
5-6: Minor: Path format inconsistency between main/types and exports root.The root
mainfield (line 5) usesdist/index.jswithout a leading dot, while the exports root (line 46-47) uses./dist/index.jswith a leading dot. The subpath exports (lines 50, 54, 58) consistently use the./dist/prefix. Consider normalizing to use./dist/throughout for consistency.- "main": "dist/index.js", + "main": "./dist/index.js",Also applies to: 45-48
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
44-63: All exported subpaths are correctly configured and will be built successfully.Verification complete: The source structure confirms all four subpaths (chains, contracts, releases, and root index) exist in
src/and will be compiled todist/by the build system. The justfile'stsc-buildrecipe outputs to thedist/directory with TypeScript declaration files, so all export paths in package.json are valid.The wildcard export
./dist/*remains permissive but is a deliberate design choice for this SDK. If narrower control over the public API surface is preferred, you could replace it with explicit subpaths only. Otherwise, the exports configuration is sound.
|
Saw this recently re. automating exports: https://x.com/_jxom/status/1981104535537144076 List is small now, easy to maintain, but a cool tool in case it grows over time. |

This pr addresses #14.
Summary by CodeRabbit
chains,contracts, andreleases